Skip to content

fix(service): drag transition travel times#1132

Open
louisgreiner wants to merge 2 commits into
mainfrom
lgr/1008-fix-drag-transition-travel-time
Open

fix(service): drag transition travel times#1132
louisgreiner wants to merge 2 commits into
mainfrom
lgr/1008-fix-drag-transition-travel-time

Conversation

@louisgreiner

@louisgreiner louisgreiner commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Replace #1131

Close #1008

Signed-off-by: Louis Greiner <louis.greiner@proton.me>

@aiAdrian aiAdrian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@aiAdrian

aiAdrian commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

There is a second related bug — if this has not yet been addressed, it should be tracked as a new issue.

I suspect that the same core problem is present: the times are not being calculated separately, or the backward travel time is simply forgotten during docking. This is similar to what happened during undock (and that PR only fixed the undock case).

next_bug.webm
chrome-capture-2026-06-15.webm

This PR can be merged .

@louisgreiner

Copy link
Copy Markdown
Contributor Author

I fixed this bug #1132 (comment) in a fixup commit also.

@aiAdrian

Copy link
Copy Markdown
Contributor

@louisgreiner Thank you for fixing this. Now I have a next issue found - asym.

Test:

netzgrafik.json

Undock looks good - but dock with asym. doesn't work correctyl:

asym_issue.webm

@aiAdrian aiAdrian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@louisgreiner

Copy link
Copy Markdown
Contributor Author

Indeed, the dock transition with asymmetric travel times does not work well :/ I fear there's no easy way to fix this. The expected behavior would be to split 17' into 7.5' - 2' - 7.5'

Anyway, this will be fixed naturally with the collapsed nodes feature

@louisgreiner louisgreiner moved this to Awaiting merge in Board PI 20 Jun 16, 2026
@louisgreiner louisgreiner self-assigned this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting merge

Development

Successfully merging this pull request may close these issues.

Drag transition out of the node - intermediate stop and times are strange (buggy)

2 participants