Enable full name display instead of short name in nodes by louisgreiner · Pull Request #971 · OpenRailAssociation/netzgrafik-editor-frontend

louisgreiner · 2026-04-29T11:47:55Z

Enregistrement.de.l.ecran.2026-05-12.103732.mp4

aiAdrian · 2026-05-04T06:00:17Z

chrome-capture-2026-05-04.mp4

The long names should also be displayed in

Pearlsview
Streckengrafik (graphical timetable)
O/D Matrix

But the general idea of the feature is good.

louisgreiner · 2026-05-05T12:44:30Z

Perlenkette, OD Matrix and Streckengrafik also react to this new parameter.

The PR is ready to review.

I'm only concerned on how to truncate the strings if the name is too long (for editor-main-view and perlenkette only (please note that "nodes" in the editor-main-view and the perlenkette do not have the same size, so the truncating can differ from a component to the other...).

aiAdrian

LGTM! Very nice new feature

aiAdrian

chrome-capture-2026-05-07.mp4

Reset button!

Pivouane

LGTM

emersion · 2026-06-12T16:36:03Z

Seems like perlenkette is a little bit off:

…main-view Signed-off-by: Louis Greiner <louis.greiner@proton.me> Signed-off-by: pierre santamaria <pierre.santamaria@epita.fr>

Signed-off-by: Louis Greiner <louis.greiner@proton.me>

…ngrafik Signed-off-by: Louis Greiner <louis.greiner@proton.me>

…ette Signed-off-by: Louis Greiner <louis.greiner@proton.me>

…streckengrafik

louisgreiner · 2026-06-15T10:01:51Z

I cannot reproduce the bug on the Perlenkette (#971 (comment)) :/

Do you have a repro @emersion?

emersion · 2026-06-15T13:02:44Z

I cannot reproduce the bug on the Perlenkette (#971 (comment)) :/

Import networkGraphic(23).json
Turn on full node names display
Open Perlenkette

(Tested on Firefox with latest commit.)

louisgreiner · 2026-06-15T14:35:27Z

This new filter is emitted in another PR: #1139

louisgreiner · 2026-06-16T13:37:30Z

I can't reproduce the bug on Perlenkette, using the demo preview and following your instructions @emersion :/

https://web-preview.openrailassociation.org/nge-pr-971/

emersion · 2026-06-16T13:45:35Z

I'm using the demo preview as well.

louisgreiner · 2026-06-16T13:48:58Z

I'm using Firefox 140.11.0esr (old version I guess), could this be the reason why?

louisgreiner requested review from Math-R and Pivouane April 29, 2026 11:47

github-actions Bot deployed to demo April 29, 2026 11:50 View deployment

emersion reviewed Apr 29, 2026

View reviewed changes

Comment thread src/app/view/editor-main-view/data-views/nodes.view.ts Outdated

emersion reviewed Apr 29, 2026

View reviewed changes

Comment thread src/app/sample-netzgrafik/netzgrafik_default.json Outdated

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from f5f71d1 to 8186178 Compare April 29, 2026 12:37

github-actions Bot deployed to demo April 29, 2026 12:39 View deployment

github-actions Bot deployed to demo April 29, 2026 13:26 View deployment

emersion reviewed Apr 29, 2026

View reviewed changes

Comment thread src/app/view/editor-main-view/data-views/nodes.view.ts Outdated

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from f731414 to 05707a0 Compare May 5, 2026 08:49

github-actions Bot deployed to demo May 5, 2026 08:51 View deployment

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from 3b77efd to 9bc26b0 Compare May 5, 2026 10:15

github-actions Bot deployed to demo May 5, 2026 10:17 View deployment

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from 6c85184 to e3b0721 Compare May 5, 2026 12:34

github-actions Bot deployed to demo May 5, 2026 12:37 View deployment

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from e3b0721 to 54a64b0 Compare May 5, 2026 12:39

github-actions Bot deployed to demo May 5, 2026 12:42 View deployment

louisgreiner marked this pull request as ready for review May 5, 2026 12:42

louisgreiner requested a review from a team as a code owner May 5, 2026 12:42

louisgreiner requested a review from emersion May 5, 2026 13:32

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from 54a64b0 to 3fb8a44 Compare May 5, 2026 13:35

github-actions Bot deployed to demo May 5, 2026 13:37 View deployment

aiAdrian approved these changes May 7, 2026

View reviewed changes

aiAdrian requested changes May 7, 2026

View reviewed changes

louisgreiner added this to Board PI 20 May 7, 2026

louisgreiner moved this to Awaiting merge in Board PI 20 May 7, 2026

louisgreiner self-assigned this May 7, 2026

louisgreiner requested a review from aiAdrian May 12, 2026 07:58

Pivouane approved these changes May 26, 2026

View reviewed changes

louisgreiner changed the title ~~feat: enable full name display instead of short name in nodes~~ feat(view): enable full name display instead of short name in nodes May 29, 2026

louisgreiner changed the title ~~feat(view): enable full name display instead of short name in nodes~~ Enable full name display instead of short name in nodes May 29, 2026

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from e334a2b to 3df7097 Compare May 29, 2026 08:33

github-actions Bot deployed to demo May 29, 2026 08:34 View deployment

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch 3 times, most recently from 180ad22 to d5f8f0c Compare May 29, 2026 08:36

github-actions Bot deployed to demo May 29, 2026 08:38 View deployment

emersion reviewed Jun 12, 2026

View reviewed changes

Comment thread src/app/streckengrafik/components/slider/path-slider/path-slider.component.ts Outdated

Comment thread src/app/view/editor-main-view/data-views/nodes.view.ts Outdated

louisgreiner added 4 commits June 15, 2026 11:25

feat(view): enable full name display instead of short name in editor-…

f17c55d

…main-view Signed-off-by: Louis Greiner <louis.greiner@proton.me> Signed-off-by: pierre santamaria <pierre.santamaria@epita.fr>

feat(view): enable full name display instead of short name od-matrix

09f5c1a

Signed-off-by: Louis Greiner <louis.greiner@proton.me>

feat(view): enable full name display instead of short name in strecke…

e7d5be2

…ngrafik Signed-off-by: Louis Greiner <louis.greiner@proton.me>

feat(view): enable full name display instead of short name in perlenk…

d086155

…ette Signed-off-by: Louis Greiner <louis.greiner@proton.me>

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from d5f8f0c to d086155 Compare June 15, 2026 09:32

github-actions Bot deployed to demo June 15, 2026 09:33 View deployment

louisgreiner added 2 commits June 15, 2026 11:35

fixup! feat(view): enable full name display instead of short name in …

a315565

…streckengrafik

fixup! feat(view): enable full name display instead of short name in …

fab09f3

…streckengrafik

github-actions Bot deployed to demo June 15, 2026 09:53 View deployment

github-actions Bot deployed to demo June 15, 2026 13:27 View deployment

louisgreiner force-pushed the lgr/enable-full-name-in-nodes branch from ffafa5a to fab09f3 Compare June 15, 2026 14:34

github-actions Bot deployed to demo June 15, 2026 14:36 View deployment

louisgreiner requested a review from emersion June 16, 2026 13:36

Conversation

louisgreiner commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aiAdrian commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

louisgreiner commented May 5, 2026

Uh oh!

aiAdrian left a comment

Choose a reason for hiding this comment

Uh oh!

aiAdrian left a comment

Choose a reason for hiding this comment

Uh oh!

Pivouane left a comment

Choose a reason for hiding this comment

Uh oh!

emersion commented Jun 12, 2026

Uh oh!

Uh oh!

Uh oh!

louisgreiner commented Jun 15, 2026

Uh oh!

emersion commented Jun 15, 2026

Uh oh!

louisgreiner commented Jun 15, 2026

Uh oh!

louisgreiner commented Jun 16, 2026

Uh oh!

emersion commented Jun 16, 2026

Uh oh!

louisgreiner commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

louisgreiner commented Apr 29, 2026 •

edited

Loading

aiAdrian commented May 4, 2026 •

edited

Loading