front: stop autoselecting direction on oneway toggle#13145
Conversation
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
emersion
left a comment
There was a problem hiding this comment.
I personally don't think the deviation from upstream NGE and the additional maintenance complexity is worth the trouble here.
(If we are to merge this PR anyways, I find comparing path steps pretty fragile, and would prefer to find another way - e.g. by bubbling up more information from NGE.)
See also #13033 (comment)
|
Since we request the back for the path steps information, I think the comparison should hold stronger than before - it does not matter if one step uses a trigram and the other an uic for example. We could also further change the fork indeed to get out more information, but that also means we have even more maintenance cost. For the comment you left on the issue, I agree, but I had no aim of changing that in these prs. My only aim is to make sure we can choose which of the train gets deleted. Given that the forward and return train in osrd can deviate and/or contain specific information not recoverable from nge, I think there is a reasonable business case here. |
|
Superseded by #15467 |
Close #13033
Depends on #osrd-project/netzgrafik-editor-frontend/17. As soon as it is merged, the nge fork version should be updated in the second commit of this pr.
The function added in the first commit should probably live in some utils file somewhere, not sure where yet.