Skip to content

front: stop autoselecting direction on oneway toggle#13145

Closed
Synar wants to merge 2 commits into
devfrom
ali/stop-autoselecting-direction-on-oneway-toggle
Closed

front: stop autoselecting direction on oneway toggle#13145
Synar wants to merge 2 commits into
devfrom
ali/stop-autoselecting-direction-on-oneway-toggle

Conversation

@Synar

@Synar Synar commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Close #13033

Depends on #osrd-project/netzgrafik-editor-frontend/17. As soon as it is merged, the nge fork version should be updated in the second commit of this pr.

The function added in the first commit should probably live in some utils file somewhere, not sure where yet.

Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar requested a review from a team as a code owner September 10, 2025 00:25
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Sep 10, 2025

@emersion emersion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think the deviation from upstream NGE and the additional maintenance complexity is worth the trouble here.

(If we are to merge this PR anyways, I find comparing path steps pretty fragile, and would prefer to find another way - e.g. by bubbling up more information from NGE.)

See also #13033 (comment)

@Synar

Synar commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Since we request the back for the path steps information, I think the comparison should hold stronger than before - it does not matter if one step uses a trigram and the other an uic for example.

We could also further change the fork indeed to get out more information, but that also means we have even more maintenance cost.

For the comment you left on the issue, I agree, but I had no aim of changing that in these prs. My only aim is to make sure we can choose which of the train gets deleted. Given that the forward and return train in osrd can deviate and/or contain specific information not recoverable from nge, I think there is a reasonable business case here.

@Synar

Synar commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #15467

@Synar Synar closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When transforming a round trip into a one way, one of the trains is deleted arbitrarily and too fast

2 participants