front: vendor bootstrap sncf #14477
Open
front: vendor bootstrap sncf #14477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khoyo
force-pushed
the
yk/vendor-bootstrap-sncf
branch
from
b53cf3f to
cd3d211
Compare
Khoyo
force-pushed
the
yk/vendor-bootstrap-sncf
branch
from
df5270f to
2c43074
Compare
Khoyo
force-pushed
the
yk/vendor-bootstrap-sncf
branch
from
2c43074 to
08f5e39
Compare
This dependency has been unmaintained since 2019 (from the last commit before the anouncement). We want to migrate from it, but we should probably vendor it in and cut out what we don't use first. For attribution and license purposes, this comes from https://github.com/SNCFdevelopers/bootstrap-sncf/tree/c810763533302706ff7cab8834761d82603ad25e/src/scss Signed-off-by: Younes Khoudli <[email protected]>
We don't use site-extern, the docs, or dark classes. This might be squashed in the previous commit? Signed-off-by: Younes Khoudli <[email protected]>
Signed-off-by: Younes Khoudli <[email protected]>
Khoyo
force-pushed
the
yk/vendor-bootstrap-sncf
branch
from
08f5e39 to
52f03ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency has been unmaintained since 2019 (from the last commit before the anouncement). We want to migrate from it, but we should probably vendor it in and cut out what we don't use first.
This also remove a fair number of dependencies, since we're not using any of the bootstrap-sncf js components. Getting to zero security alerts is now an achievable target...
For attribution and license purposes, this comes from https://github.com/SNCFdevelopers/bootstrap-sncf/tree/c810763533302706ff7cab8834761d82603ad25e/src/scss
Note to reviewers: all commits will be squashed before merging, the first one is probably the most interesting one.