front: clean code related to trainSchedules #14551
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
This function was used to distinguish PacedTrainWithDetails from TrainScheduleWithDetails. As TrainScheduleWithDetails was dropped, this function is not useful anymore. Signed-off-by: Clara Ni <[email protected]>
Now that trainSchedules have been dropped, we can rename some utils. PacedTrains will always have a paced field from now on, so we can rename the function isPacedTrainWithPaced by isPacedTrainBase. Signed-off-by: Clara Ni <[email protected]>
Now that trainSchedules have been dropped, we can rename some utils. PacedTrains will always have a paced field from now on, so we can rename the function isPacedTrainResponseWithPaced to isPacedTrain. Signed-off-by: Clara Ni <[email protected]>
…ails Now that trainSchedules have been dropped, we can rename some utils. PacedTrains will always have a paced field from now on, so we can rename the function isPacedTrainWithPacedWithDetails to isPacedTrainWithDetails. Signed-off-by: Clara Ni <[email protected]>
Since TrainSchedules have been dropped, these types are not useful anymore. Signed-off-by: Clara Ni <[email protected]>
Since TrainSchedules have been removed, we can merge the types PacedTrainWithPacedTrainId and TimetableItem. Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/adapt-paced-train-schema-5
branch
from
bef3369 to
b06479a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits