-
Notifications
You must be signed in to change notification settings - Fork 2
Reactive rewrite #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reactive rewrite #17
Conversation
awesome, seems like its just looking over and fixing the documentation that's needed now. i made a bit of a checklist in the pull request to give a bit of an outline as to what documentation may be affected by this change |
…w bluetooth backend
@Aldaniee ok, it looks like this should be all ready now - just updated a bunch of the docs. are you happy with the way the demo app works on iOS based on your testing? any other testing you want to do (or think needs to be done)? |
It's been some time, I will have a look whether this pull request is still relevant today. |
That would be awesome, thanks! GitHub doesnt seem to think theres any conflicts and i doubt things have significantly moved on main since the last commit to this feature branch. but id definitely still want to refresh myself on the code to remember what i was doing and why |
I do not have access to an iphone so I can't migrate iOS (assuming that is required). I have managed to build & run on Android with flutter version 3.29.2 and java 21. At the moment I can scan and connect. I can send and receive CSAFE commands. I haven't tested further. |
check out https://github.com/openRowingCommunity/OpenErgView - its a low-fi version of the old ergdata app i built using this library - maybe thats a good live-data testcase |
I was thinking of something less sophisticated, I do not want to prolong this (big enough) PR too much. I will test from the OpenErgView to bridge any gap in feature/compatibility. |
Replaced by #23 |
due to a specific issue( dotintent/FlutterBleLib#625) and apparrent lack of support or maintainence with the existing FlutterBleLib library, this pull request implements a small rewrite to swap this bluetooth backend with flutter_reactive_ble which seems to be maintained by Philips Hue.
Also we should give the documentation a quick once-over to make sure it represents the latest state of things:
docs
folders