Skip to content

Reactive rewrite #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Reactive rewrite #17

wants to merge 32 commits into from

Conversation

MoralCode
Copy link
Collaborator

@MoralCode MoralCode commented Nov 16, 2022

due to a specific issue( dotintent/FlutterBleLib#625) and apparrent lack of support or maintainence with the existing FlutterBleLib library, this pull request implements a small rewrite to swap this bluetooth backend with flutter_reactive_ble which seems to be maintained by Philips Hue.

Also we should give the documentation a quick once-over to make sure it represents the latest state of things:

  • inline documentation comments
  • README
    • content
    • demo app screenshots
  • repo wikis or any standalone docs in docs folders
    • DesignDecisions.md, bluetooth library section
    • internals.md, Internal API Design section is TBD

@MoralCode
Copy link
Collaborator Author

awesome, seems like its just looking over and fixing the documentation that's needed now. i made a bit of a checklist in the pull request to give a bit of an outline as to what documentation may be affected by this change

@MoralCode
Copy link
Collaborator Author

@Aldaniee ok, it looks like this should be all ready now - just updated a bunch of the docs. are you happy with the way the demo app works on iOS based on your testing? any other testing you want to do (or think needs to be done)?

@MonsieurRz
Copy link

MonsieurRz commented Apr 5, 2025

It's been some time, I will have a look whether this pull request is still relevant today.

@MoralCode
Copy link
Collaborator Author

It's been some time, I will have a look whether this pull request is still relevant today.

That would be awesome, thanks!

GitHub doesnt seem to think theres any conflicts and i doubt things have significantly moved on main since the last commit to this feature branch. but id definitely still want to refresh myself on the code to remember what i was doing and why

@MonsieurRz
Copy link

I do not have access to an iphone so I can't migrate iOS (assuming that is required).

I have managed to build & run on Android with flutter version 3.29.2 and java 21.
The most difficult thing was to migrate the android build. I will clean and push that next week.

At the moment I can scan and connect. I can send and receive CSAFE commands. I haven't tested further.
Next I think I will take some time to improve the example's UI so I can add live data streaming.

@MonsieurRz MonsieurRz mentioned this pull request Apr 6, 2025
8 tasks
@MoralCode
Copy link
Collaborator Author

Next I think I will take some time to improve the example's UI so I can add live data streaming.

check out https://github.com/openRowingCommunity/OpenErgView - its a low-fi version of the old ergdata app i built using this library - maybe thats a good live-data testcase

@MonsieurRz
Copy link

I was thinking of something less sophisticated, I do not want to prolong this (big enough) PR too much.

I will test from the OpenErgView to bridge any gap in feature/compatibility.

@MonsieurRz
Copy link

Replaced by #23
@MoralCode you can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants