Add Noise Gate#43
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a noise gate stage for the audio processing chain to eliminate unwanted noise when not playing. The noise gate features configurable threshold, ratio, attack, hold, and release parameters with smooth transitions to avoid abrupt audio cuts.
Key changes:
- Implements a complete NoiseGateStage with envelope following and smooth gating transitions
- Adds GUI configuration and controls for all noise gate parameters
- Integrates the noise gate into the existing stage system with proper message handling
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sim/stages/noise_gate.rs | Core noise gate implementation with envelope tracking and parameter controls |
| src/sim/stages/mod.rs | Exports the new noise_gate module |
| src/gui/messages.rs | Adds NoiseGateMessage enum for GUI communication |
| src/gui/config/noise_gate.rs | Configuration struct with default values and stage conversion |
| src/gui/config/mod.rs | Integrates noise gate config into the stage system |
| src/gui/components/stages/noise_gate.rs | GUI component with sliders for all parameters |
| src/gui/components/stages/mod.rs | Exports the noise gate GUI component |
| src/gui/components/stage_list.rs | Renders noise gate stages in the stage list |
| src/gui/components/control.rs | Adds noise gate to available stage types |
| src/gui/app.rs | Handles noise gate messages and builds stages in the amplifier chain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22