Skip to content

Add Noise Gate#43

Merged
OpenSauce merged 3 commits into
mainfrom
add-noise-gate
Aug 9, 2025
Merged

Add Noise Gate#43
OpenSauce merged 3 commits into
mainfrom
add-noise-gate

Conversation

@OpenSauce

Copy link
Copy Markdown
Owner

Closes #22

Copilot AI review requested due to automatic review settings August 9, 2025 16:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a noise gate stage for the audio processing chain to eliminate unwanted noise when not playing. The noise gate features configurable threshold, ratio, attack, hold, and release parameters with smooth transitions to avoid abrupt audio cuts.

Key changes:

  • Implements a complete NoiseGateStage with envelope following and smooth gating transitions
  • Adds GUI configuration and controls for all noise gate parameters
  • Integrates the noise gate into the existing stage system with proper message handling

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/sim/stages/noise_gate.rs Core noise gate implementation with envelope tracking and parameter controls
src/sim/stages/mod.rs Exports the new noise_gate module
src/gui/messages.rs Adds NoiseGateMessage enum for GUI communication
src/gui/config/noise_gate.rs Configuration struct with default values and stage conversion
src/gui/config/mod.rs Integrates noise gate config into the stage system
src/gui/components/stages/noise_gate.rs GUI component with sliders for all parameters
src/gui/components/stages/mod.rs Exports the noise gate GUI component
src/gui/components/stage_list.rs Renders noise gate stages in the stage list
src/gui/components/control.rs Adds noise gate to available stage types
src/gui/app.rs Handles noise gate messages and builds stages in the amplifier chain

Comment thread src/sim/stages/noise_gate.rs Outdated
Comment thread src/gui/config/noise_gate.rs Outdated
Comment thread src/gui/components/stages/noise_gate.rs Outdated
@OpenSauce OpenSauce enabled auto-merge (squash) August 9, 2025 16:24
@OpenSauce OpenSauce merged commit 1c3e640 into main Aug 9, 2025
2 checks passed
@OpenSauce OpenSauce deleted the add-noise-gate branch August 9, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Noise Gate Stage

2 participants