feat(memory-server): dual-write generic task columns#249
Merged
Hyperkid123 merged 2 commits intoJun 17, 2026
Conversation
… paths RHCLOUD-48377 — Stage 2 of generic task system migration. Every write path now populates both old (jira_key, pr_number, pr_url) and new (external_key, source_type, source_url, artifacts) columns simultaneously. - Extract shared build_artifacts() + JIRA_BASE_URL to artifacts.py - task_add: derives external_key/source_type/source_url/artifacts from jira_key - task_update: rebuilds artifacts when PR fields or metadata.prs change - bot_status_update: sets external_key/source_type in singleton + multi-instance - memory_store: sets external_key/source_type from jira_key - slack_notify: sets external_key/source_type from jira_key - api_costs_add: sets external_key/source_type on cycles INSERT - api_memory_upload: sets external_key/source_type on memories INSERT - api_bot_status_update: sets external_key/source_type on bot_status UPDATE - Add Pydantic model fields for new columns (Task, Memory) - Fix pre-existing lint issues (unused imports, dead code) - Add 11 dual-write tests covering all write paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RHCLOUD-48377 Proper Python package structure so relative imports work. - git mv src/ → bot_memory_server/ - Add [build-system] + setuptools config to pyproject.toml - Update all test imports from src.* to bot_memory_server.* - Remove sys.path hacks from test files - Update Dockerfile, Makefile, docker-compose, vite config - Update .gitignore paths for dashboard build output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 2 of the generic task system migration (RHCLOUD-48377).
Every write path now populates both the old (
jira_key,pr_number,pr_url) and new (external_key,source_type,source_url,artifacts) columns simultaneously. No read path changes, no bot behavior changes, no CLAUDE.md changes.Changes
artifacts.py— sharedbuild_artifacts()helper +JIRA_BASE_URLconstant, extracted from migrationtask_add,task_update,bot_status_updateall dual-write new columnsmemory_storedual-writesexternal_key/source_typeslack_notifydual-writesexternal_key/source_typeapi_costs_add,api_memory_upload,api_bot_status_updatedual-write new columnsTaskandMemorymodels include new fields in responsesWhat this does NOT change
task_add(jira_key=...))jira_keyWHERE clauses)Test plan
ruff check+ruff formatcleanRHCLOUD-48377