fix(dashboard): hide download button when no transcript, fix orphan grouping#250
Merged
Hyperkid123 merged 1 commit intoJun 17, 2026
Merged
Conversation
…rouping RHCLOUD-48541 - Add has_transcript boolean to cycle run API list responses - Conditionally render download button only when transcript exists - Use progress.jira_key as fallback for by-task grouping when task_id is null - Extract task_id from progress_store results in bot agent context Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two UX issues on the cycle runs dashboard page:
Download button hidden when no transcript — The download arrow now only appears on cycle runs that actually have a stored transcript, preventing silent 404 errors when users click it.
Orphan grouping fix — Cycle runs without a
task_idbut with ajira_keyin their progress data are now grouped under their ticket instead of "Orphan cycles". UsesCOALESCE(t.jira_key, cr.progress->>'jira_key')in the by-task grouping query.Bot agent extraction fix —
_extract_task_id_from_result()now also extractstask_idfromprogress_storecycle run results, preventing future orphan runs when the bot callsprogress_storebefore transcript upload.Closes RHCLOUD-48541
Changes
memory-server/bot_memory_server/api.py— Addhas_transcriptboolean to list columns, COALESCE fallback in by-task groupingdashboard/src/types.ts— Addhas_transcripttoCycleRuninterfacedashboard/src/components/CycleRunCard.tsx— Conditionally render download buttondashboard/src/pages/CycleRuns.tsx— Show "No transcript available" message in detail viewbot/agent.py— Extracttask_idfromprogress_storeresults, extractjira_keyfrom progress dictTest plan
python -m pytest tests/— 26 tests passnpm run build— dashboard builds cleanlyprogress.jira_keygroup under their ticket