Skip to content

Make macOS DMG filename arch-aware (arm64 / x86_64) #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geekrebel wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −2
Open

Make macOS DMG filename arch-aware (arm64 / x86_64) #6004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions installer/build_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,10 @@ def main():
app_name += "-x86_64.AppImage"
app_upload_bucket = "releases.openshot.org/linux"
elif platform.system() == "Darwin":
app_name += "-x86_64.dmg"
# Apple Silicon (arm64) and Intel (x86_64) Macs produce arch-suffixed
# DMGs so both can be published side-by-side to the mac release bucket.
mac_arch = "arm64" if platform.machine() == "arm64" else "x86_64"
app_name += "-%s.dmg" % mac_arch
app_upload_bucket = "releases.openshot.org/mac"
elif platform.system() == "Windows" and not windows_32bit:
app_name += "-x86_64.exe"
Expand Down Expand Up @@ -506,7 +509,7 @@ def main():
os.remove(app_build_path)

if platform.system() == "Darwin":
# Create DMG (OpenShot-%s-x86_64.DMG)
# Create DMG (OpenShot-%s-arm64.dmg or OpenShot-%s-x86_64.dmg)
app_image_success = False

# Build app.bundle and create DMG
Expand Down