Fix tiny 1080p video output caused by capped media metadata#6012
Open
ErbolTakhirov wants to merge 2 commits into
Open
Fix tiny 1080p video output caused by capped media metadata#6012ErbolTakhirov wants to merge 2 commits into
ErbolTakhirov wants to merge 2 commits into
Conversation
…tiny preview dimensions caused by SetMaxDecodeSize. Added a project-load repair step for already affected projects: OpenShot re-reads suspiciously small video files and updates the real dimensions on the file and linked clips. Updated tests for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Why:
In daily builds, some imported FHD videos could be stored with tiny dimensions.
When exporting as FHD 29.97 fps, those clips could appear very small inside the final 1920x1080 frame.
Keeping real source dimensions prevents incorrect scaling during export.
How to test:
Import a 1920x1080 video.
Confirm the imported file properties show 1920x1080.
Export using YouTube HD / FHD 1080p 29.97 fps.
Open the exported video and confirm it fills the 1080p frame correctly.
Optional: open an older affected project and confirm the same clip is repaired and exports at the correct size.
Checks
Ran Python syntax checks with py_compile.
Full unit tests could not be run in this environment because no Qt binding is installed (PyQt6, PySide6, or PyQt5).