[rel-DB] Fix different tests #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanott
reviewed
Oct 7, 2025
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
In general I think that as long as the tests are running we don't need to do the clean-ups now. But it makes sense to do them while we are editing the files anyway. So let's keep your changes here.
| data: dict[str, Any], | ||
| collection: Literal["assignment", "motion"], | ||
| sub_collection: str, | ||
| back_relation: str, |
Member
There was a problem hiding this comment.
Amazing how this function shrank.
vkrasnovyd
merged commit 9e52dbb
into
OpenSlides:feature/relational-db
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user.test_merge_together.pyfile, I've spot quite a bunch of back relations that were set manually. Cleaned up some of them but there are still a lot of them left. Do we want to remove them all too? Probably from the whole directory and in a separate PR? If that's the case, I'll move this commit to a new branch.