Update Night Sky Panel's Markings tab + Small Sun Tab refactor#207
Conversation
|
The layout is now more responsive and uses an adaptive gridding similar to the skybrowser panel. Demonstration: 2026-03-20.09-43-50.mov |
Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
# Conflicts: # src/panels/NightSkyPanel/tabs/MarkingsTab/SceneGraphNodeToggle.tsx
# Conflicts: # src/panels/NightSkyPanel/tabs/MarkingsTab/CardinalDirectionsBoxes.tsx # src/panels/NightSkyPanel/tabs/MarkingsTab/ConstellationsArtToggle.tsx # src/panels/NightSkyPanel/tabs/MarkingsTab/ConstellationsLabelsToggle.tsx # src/panels/NightSkyPanel/tabs/MarkingsTab/ConstellationsLinesToggle.tsx # src/panels/NightSkyPanel/tabs/MarkingsTab/MarkingBox.tsx
|
Actions now available here: https://github.com/OpenSpace/OpenSpace-WebGui/pull/207/changes and I updated this branch to call them. |
…com/OpenSpace/OpenSpace-WebGui into issue/3753-nightsky-markings-layout
|
The "Cardinal Directions" part's design was changed once again... Now it corresponds more to how it actually works - with the scene graph node being enabled/disabled and then which texture is set. It also allows setting the visuals before showing the direction. This is how it looks now: 
|
|
Looks and works great! Tested all the changes, and I updated the actions in the main repo to fix the hide all stuff |
engbergandreas
left a comment
engbergandreas
left a comment
There was a problem hiding this comment.
Sorry for all the onClick functions, but might as well get through them. We should probably make a separate pass through on this so that we're up-to-date with our readme. I only looked at the code and nothing sticks out. Looks way nicer now, great job!
| /** | ||
| * The identifier of the scene graph node that this toggle represents | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * The identifier of the scene graph node that this toggle represents | |
| */ | |
| // The identifier of the scene graph node that this toggle represents |
?
There was a problem hiding this comment.
Unfortunately, this has to be a block comment for it to be visible on hover over the property name. But I guess we could also skip it
There was a problem hiding this comment.
Note that we're currently very incosistnet wiht how we document props. It's probably something we should discuss at some point
There was a problem hiding this comment.
Yea, but then we can leave it as a block comment for now
Co-authored-by: Andreas Engberg <48772850+engbergandreas@users.noreply.github.com> Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
Night Sky Panel OpenSpace/OpenSpace-WebGui#207
4 participants
Closes OpenSpace/OpenSpace#3753 by adding a new ToggleCard component and improving the layout in the Night Sky Panel's Markings tab. IN discussion with @ylvaselling, I also changed the design for the Cardinal directions part to better reflect how this control works, and that it's different from the other toggles.
Drafting as the following needs to be fixed before merging:
New VS old Markings tab:
New VS old Sun tab:
