Fix disappearing labels for fading checkbox #215
Merged
WeirdRubberDuck merged 2 commits intoMay 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “fading” visibility UI for property owners so that the label no longer disappears during fade transitions, by rendering a Mantine Checkbox (with an animated icon) instead of a standalone icon button.
Changes:
- Render a
Checkbox(withindeterminatestate) whenvisibility === 'Fading'to keep the label visible. - Replace the previous CSS-based
FadeIconimplementation with a new SVG-basedFadeAnimationIcon. - Remove the old
FadeIconcomponent and its CSS module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/PropertyOwner/VisiblityCheckbox.tsx | Uses a Mantine Checkbox (with custom icon) in the Fading state so the label remains visible. |
| src/components/PropertyOwner/FadeIcon.tsx | Removes the previous ActionIcon-based fading indicator implementation. |
| src/components/PropertyOwner/FadeIcon.module.css | Removes keyframe animation styles used by the deleted FadeIcon. |
| src/components/PropertyOwner/FadeAnimationIcon.tsx | Adds a new animated SVG icon used in the checkbox for the Fading state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexanderbock
approved these changes
May 8, 2026
WeirdRubberDuck
added a commit
to OpenSpace/OpenSpace
that referenced
this pull request
May 11, 2026
Fading checkbox fix and update (OpenSpace/OpenSpace-WebGui#215) #4045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes OpenSpace/OpenSpace#4045
Use a checkbox also for the fading state. Replace the previous "icon" with an animated SVG
Inspelning.2026-05-08.115619.mp4