Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 28, 2025

Note: this new test case does not cover the fix.

Only run all ui test case and then LabelsHiddenModifierUITests.toggleLabelsHidden will hit the recursive loop and cause infinite loop call for FunctionalLocation==.

Thread 0 Crashed:
0   libswiftCore.dylib            	       0x195a95f90 0x1957bb000 + 2994064
1   TestingHost.debug.dylib       	       0x10452c66c type metadata accessor for FunctionalLocation + 24
2   TestingHost.debug.dylib       	       0x10452b3e8 static FunctionalLocation.== infix(_:_:) + 188
3   TestingHost.debug.dylib       	       0x10452b548 protocol witness for static Equatable.== infix(_:_:) in conformance FunctionalLocation<A> + 16
4   AttributeGraph                	       0x1c00f153c 0x1c00c1000 + 197948
5   AttributeGraph                	       0x1c00db6e0 0x1c00c1000 + 108256
6   AttributeGraph                	       0x1c00dbb30 0x1c00c1000 + 109360
7   AttributeGraph                	       0x1c00f1640 0x1c00c1000 + 198208
8   AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
9   AttributeGraph                	       0x1c00f14e8 0x1c00c1000 + 197864
10  AttributeGraph                	       0x1c00f1498 0x1c00c1000 + 197784
11  AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
12  AttributeGraph                	       0x1c00f1478 0x1c00c1000 + 197752
13  TestingHost.debug.dylib       	       0x10452b404 static FunctionalLocation.== infix(_:_:) + 216 (Location.swift:366)
14  TestingHost.debug.dylib       	       0x10452b548 protocol witness for static Equatable.== infix(_:_:) in conformance FunctionalLocation<A> + 16
15  AttributeGraph                	       0x1c00f153c 0x1c00c1000 + 197948
16  AttributeGraph                	       0x1c00db6e0 0x1c00c1000 + 108256
17  AttributeGraph                	       0x1c00dbb30 0x1c00c1000 + 109360
18  AttributeGraph                	       0x1c00f1640 0x1c00c1000 + 198208
19  AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
20  AttributeGraph                	       0x1c00f14e8 0x1c00c1000 + 197864
21  AttributeGraph                	       0x1c00f1498 0x1c00c1000 + 197784
22  AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
23  AttributeGraph                	       0x1c00f1478 0x1c00c1000 + 197752
24  TestingHost.debug.dylib       	       0x10452b404 static FunctionalLocation.== infix(_:_:) + 216 (Location.swift:366)
25  TestingHost.debug.dylib       	       0x10452b548 protocol witness for static Equatable.== infix(_:_:) in conformance FunctionalLocation<A> + 16
26  AttributeGraph                	       0x1c00f153c 0x1c00c1000 + 197948
27  AttributeGraph                	       0x1c00db6e0 0x1c00c1000 + 108256
28  AttributeGraph                	       0x1c00dbb30 0x1c00c1000 + 109360
29  AttributeGraph                	       0x1c00f1640 0x1c00c1000 + 198208
30  AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
31  AttributeGraph                	       0x1c00f14e8 0x1c00c1000 + 197864
32  AttributeGraph                	       0x1c00f1498 0x1c00c1000 + 197784
33  AttributeGraph                	       0x1c00eaf5c 0x1c00c1000 + 171868
34  AttributeGraph                	       0x1c00f1478 0x1c00c1000 + 197752
35  TestingHost.debug.dylib       	       0x10452b404 static FunctionalLocation.== infix(_:_:) + 216 (Location.swift:366)
36  TestingHost.debug.dylib       	       0x10452b548 protocol witness for static Equatable.== infix(_:_:) in conformance FunctionalLocation<A> + 16

Note: this test does not cover the fix. Only run all ui test case and then LabelsHiddenModifierUITests.toggleLabelsHidden will hit the recursive loop
@github-actions github-actions bot added bug Something isn't working crash test Test related issue P0 Top priority labels Oct 28, 2025
@Kyle-Ye Kyle-Ye changed the title Fix UITest stack overflow Fix UITest case crash for LabelsHiddenModifierUITests Oct 28, 2025
@Kyle-Ye Kyle-Ye merged commit a07f255 into main Oct 28, 2025
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/location branch October 28, 2025 17:12
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.94%. Comparing base (ab02ac4) to head (2534c62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   30.84%   30.94%   +0.09%     
==========================================
  Files         540      537       -3     
  Lines       32279    31891     -388     
==========================================
- Hits         9956     9868      -88     
+ Misses      22323    22023     -300     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working crash P0 Top priority test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants