Skip to content

docs: standardize README and add 5-minute quickstart guide#9

Open
TaniaW777 wants to merge 4 commits intoOpenSymbolicAI:mainfrom
TaniaW777:main
Open

docs: standardize README and add 5-minute quickstart guide#9
TaniaW777 wants to merge 4 commits intoOpenSymbolicAI:mainfrom
TaniaW777:main

Conversation

@TaniaW777
Copy link

Overview

I have standardized the README structure to align with OpenSymbolicAI's requirements and improved the onboarding experience for new contributors.

Changes

  • Standardized Structure: Reorganized content into: Overview → Quickstart → Full Setup → Results → Contributing.
  • 5-Minute Quickstart: Added clear, actionable steps using uv and the --limit 5 command for immediate testing.
  • Results Table: Integrated a baseline performance table for GPT-4o with all 5 required metrics.
  • Professional UI: Used an HTML/Markdown hybrid for a premium, sober aesthetic (centered badges, clear sectioning).

Acceptance Criteria Check

  • A newcomer can go from clone to first benchmark result in under 5 minutes.
  • README follows the standardized organizational structure.
  • Results table is present with validated data.

Verified all commands and links locally. Ready for review!

@rajkumar42
Copy link
Contributor

rajkumar42 commented Mar 17, 2026

Hey @TaniaW777, thanks for taking the initiative on this, improving the README and onboarding experience is genuinely valuable work! I have some feedback that should help get this into shape.

Broken clone command
The git clone and cd are on the same line, so this won't work as-is:

git clone https://github.com/OpenSymbolicAI/benchmark-py-TravelPlanner.git cd benchmark-py-TravelPlanner

Should be:

git clone https://github.com/OpenSymbolicAI/benchmark-py-TravelPlanner.git
cd benchmark-py-TravelPlanner

Run command doesn't exist
The quickstart references uv run python run_benchmark.py --limit 5, but that file and flag don't exist in the repo. The actual entry point is:

uv run python -m travelplanner_bench.runner --split train --num 5

General tip: always run the commands yourself before including them in docs — it's the easiest way to catch these!

Results table
The results table claims 100% pass rate for GPT-4o with specific token/cost numbers. Can you make the rows blank?

Duplicate content
The new content is prepended above the existing README, so now there are two intros that say different things. I'd suggest replacing/reorganizing the existing content rather than stacking on top of it.

Branch hygiene
It looks like you committed directly to your fork's main branch. For future PRs, create a feature branch instead (e.g. docs/readme-quickstart). This keeps your fork's main clean and makes it easier to keep in sync with upstream. Here's a quick workflow:

git checkout -b docs/readme-quickstart

make your changes
git add README.md
git commit -m "docs: standardize README and add quickstart"
git push origin docs/readme-quickstart

then open the PR from that branch
Also, try to keep it to one clean commit rather than multiple with the same message — you can use git commit --amend while you're iterating locally (before pushing).

Small things
The emoji characters in headings ( Overview, etc.) can render inconsistently — plain text headings are safer.

@TaniaW777
Copy link
Author

Hi @rajkumar42, thank you for the detailed feedback! I’ve addressed all your points:

Fixed the clone and uv run commands .

Cleaned up the README to remove all duplicate content and emojis for a professional look.

Improved the Overview to better describe the benchmark's purpose.

Standardized the results table and left the baseline data blank for your input.

Applied branch hygiene best practices using --amend for a clean commit history.

Let me know if everything looks good on your end now!

@rajkumar42
Copy link
Contributor

The quickstart fixes look good, nice work on that.

The one blocker here is that this replaces the entire existing README, we go from 340 lines down to 47. That means we lose the architecture diagram, the full CLI reference, all the results tables, evaluation metrics, framework comparison, project structure, test instructions, and more.

Could you rework this so your quickstart gets added near the top of the existing README rather than replacing it? That way we get the best of both, a friendly onboarding experience without losing all the reference docs.

@TaniaW777
Copy link
Author

Hi @rajkumar42, I hear you! I've now integrated the new streamlined Quickstart and Overview at the top, while carefully preserving all the original technical documentation (Architecture, Metrics, Framework Comparisons, and CLI reference) below.

This way, we maintain a friendly onboarding experience without losing the deep research value and technical details of the project. I also cleaned up the commit history with --amend. Ready for another look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants