Add: Station/RoadStop height and blocked pillar flag lists. #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
force-pushed
the
station-bridges
branch
from
458f95e to
b0a3bee
Compare
Rito13
reviewed
Sep 1, 2025
nml/actions/action0properties.py
Outdated
|
|
||
| def station_tile_list(value, prop_num, description): | ||
| if not isinstance(value, Array) or len(value.values) % 2 != 0: | ||
| raise generic.ScriptError(description + " list must be an array of even length", value.pos) |
Contributor
There was a problem hiding this comment.
generally speaking i'd say use f-strings instead of concatenation.
Originally posted by @LordAro in #385 (comment)
PeterN
force-pushed
the
station-bridges
branch
from
b0a3bee to
eabb0ae
Compare
Contributor
|
I've been using |
PeterN
force-pushed
the
station-bridges
branch
from
eabb0ae to
0a1405d
Compare
rubidium42
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for station and road stop height and blocked pillar flag lists.
heightsfor station prop 0x20, roadstop prop 0x13.blocked_pillarsfor station prop 0x21, roadstop prop 0x14.This processes lists as provided by the author and makes no assumptions about what different tile layouts might represent.