Add: Extend FEAT_TRAIN track_type for prop 34 #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
force-pushed
the
train_prop_34
branch
from
b332494 to
fc43871
Compare
PeterN
previously approved these changes
Sep 14, 2025
Member
PeterN
left a comment
PeterN
left a comment
There was a problem hiding this comment.
Looks fine, should it be in a unit test?
Contributor
|
Confirmed working as expected in my local test. |
glx22
force-pushed
the
train_prop_34
branch
from
fc43871 to
5d3f4d3
Compare
Contributor
Author
|
Added to regression test |
PeterN
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTTD/OpenTTD#14357 added prop 34.
Extended
track_typesyntax to also accept an array of railtype labels.Prop 05 is used when there's only one label, prop 34 for more than one.