Skip to content

Conversation

@AnFreTh
Copy link
Collaborator

@AnFreTh AnFreTh commented Oct 21, 2024

This pull request includes several improvements and bug fixes across multiple files in the mambular package. The changes focus on ensuring proper type handling and updating the version number.

Version Update:

Type Handling Improvements:

  • mambular/data_utils/datamodule.py: Ensured that keys are converted to strings when constructing cat_key, binned_key, and num_key in the setup and preprocess_test_data methods. [1] [2] [3] [4]
  • mambular/models/sklearn_base_classifier.py, mambular/models/sklearn_base_lss.py, mambular/models/sklearn_base_regressor.py: Modified conditional checks to use if X_val is not None instead of if X_val in the build_model and fit methods. [1] [2] [3] [4] [5] [6]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants