bug/9664-road-user-assignment-highlighting-is-not-correct-when-loading-ottrk-before-otflow#832
Merged
randy-seng merged 7 commits intoMay 29, 2026
Conversation
Shared code style markdown files — used as reference rules for AI coding agents — that apply across multiple projects are now managed via symlinks in .claude/rules/shared rather than being committed to each repository individually. This avoids duplication and ensures changes to shared AI coding rules propagate consistently without requiring updates across all repos.
When .ottrk files are loaded before .otflow files, road user assignment highlighting is not correctly applied to all flows. The issue is that AddAllFlows was adding flows one-by-one (via AddFlow) without ensuring validation happens against all flows being added together. - Refactor AddAllFlows.add() to validate all flows upfront before adding - Validate flows against existing repository AND against other flows being added - Extract validation helpers (check_flow_already_exists, is_flow_name_valid, is_flow_id_valid, flow_with_same_start_end_section_exists) as module functions - Remove circular AddFlow dependency from AddAllFlows - Use repository.add_all() for batch insertion to ensure atomic operation - Add flows_are_unique() check to prevent duplicate flows in same batch - Update LoadOtflow to use AddAllFlows for batch loading - Expand test coverage for uniqueness and repository conflicts
dahelb
previously approved these changes
May 11, 2026
dahelb
left a comment
dahelb
left a comment
There was a problem hiding this comment.
Minor typing things. Rest looks good to me!
…s-not-correct-when-loading-ottrk-before-otflow
…s-not-correct-when-loading-ottrk-before-otflow
…` instead of `list[Flow]`
dahelb
approved these changes
May 29, 2026
randy-seng
deleted the
bug/9664-road-user-assignment-highlighting-is-not-correct-when-loading-ottrk-before-otflow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flow highlighting and exclude shared rules from version control
Summary
This pull request addresses two improvements:
Flow Highlighting Fix for
.ottrkand.otflow:.ottrkfiles were loaded before.otflowfiles.AddAllFlowsto validate all flows at once before insertion, ensuring consistency and avoiding duplicates.Exclude Shared AI Coding Rules from Version Control:
.claude/rules/sharedto use symlinks rather than committing shared code style markdown files individually across repositories.OP#9664