Add: Compile-time guards for st41 TX payload geometry - #1688
Open
awilczyns wants to merge 1 commit into
Open
Conversation
Coverity CID 561696 reports an OVERRUN in build_packet, taking sizeof(hdr->rtp) as the bound; the real extent is sizeof(st41_fmd_hdr) + max_pkt_len into a larger mbuf element, so it is a false positive. Pin the two premises that verdict rests on: max_pkt_len stays a multiple of 4 (the payload write rounds up to a whole word), and st41_fmd_hdr stays layout-identical to mt_udp_hdr + st41_rtp_hdr (the chain payload mbuf is sized from one, max_pkt_len derives from the other). Signed-off-by: Wilczynski, Andrzej <andrzej.wilczynski@intel.com>
awilczyns
force-pushed
the
add/st41-payload-geometry-guards
branch
from
August 28, 2026 07:46
3e8cd9a to
fdb29fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverity CID 561696 reports an OVERRUN in build_packet, taking sizeof(hdr->rtp) as the bound; the real extent is
sizeof(st41_fmd_hdr) + max_pkt_len into a larger mbuf element, so it is a false positive. Pin the two premises that verdict rests on: max_pkt_len stays a multiple of 4 (the payload write rounds up to a whole word), and st41_fmd_hdr stays layout-identical to mt_udp_hdr + st41_rtp_hdr (the chain payload mbuf is sized from one, max_pkt_len derives from the other).