Code review fix - #5
Closed
sunilnom wants to merge 27 commits into
Closed
Conversation
…s to BSD-3-Clause
…l three workflows
…uild and pull_request
…ths in trivy workflow
…mes, add static-analysis headings
…h; smoke-tests tests both
…d MTL builds; remove install hints from environment-check
… daily_build; gate PR jobs on env-check and build
…sh)' appearing in UI
… without an open PR
…#1 from OpenVisualCloud/rename-paths Renamed the application from TxApp to dvledtx across all source files, headers, configs, build system, and docs. Added BSD-3-Clause headers to all files. Fixed innersource URLs to point to the public GitHub repo. Removed BOM from meson.build files that was causing build failures. Refactored CI into five reusable composite actions: environment-check, build-dvledtx, smoke-tests, unit-tests, and static-analysis. Environment-check runs first and gates everything — it verifies APT packages, pip packages, system libraries, build dependencies via pkg-config, static analysis tools, and confirms FFmpeg is patched with the MTL plugin. Build action compiles two binaries (dvledtx-ffmpeg and dvledtx-mtl) and saves them outside the build directory so the clean step between builds does not wipe them. Smoke tests run -v on each binary to validate the version string and --help to confirm the binary runs. All four workflows (pull_request, daily_build, ci, trivy) now follow the same sequential structure with a single checkout, single cleanup, and all reports collected in one reports directory uploaded as a single artifact.
- session_manager.h: make frame_counter atomic for thread safety - main.c: add --test-time CLI option for timed transmit runs - config_reader.c: replace atoi with strtol, fix null-app check, handle PCI BDF regex compilation failure - logger.c: guard level check with mutex, handle freopen failure - test_config_reader.c: update null-app test to expect error return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Quality
Testing
Review Readiness
Documentation
Security
PR Type
What kind of change does this PR introduce?