Fix concurrency test bug and install modules before unit tests#222
Merged
Fix concurrency test bug and install modules before unit tests#222
Conversation
nmburgan
force-pushed
the
fix_concurrency_spec_test
branch
from
1b1d37c to
91ecde3
Compare
These tests require running 'bundle exec r10k puppetfile install' before running, so this ensures it happens before running tests. It's idempotent and only takes about a second when it's already installed, so we just run it every time. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
The default concurrency value is based on what Etc::SC_OPEN_MAX (ulimit) is set to, either divided by 7 or capped at 100. When running unit tests in an environment where this value is less than 700, it results in a number less than the expected 100. Instead, the test is now two tests where the call is stubbed and we verify both the divide by 7 and the 100 cap behavior. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
nmburgan
force-pushed
the
fix_concurrency_spec_test
branch
from
91ecde3 to
74888c7
Compare
bastelfreak
reviewed
Apr 21, 2026
jay7x
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Run install_modules before tests:unit
These tests require running 'bundle exec r10k puppetfile install' before running, so this ensures it happens before running tests. It's idempotent and only takes about a second when it's already installed, so we just run it every time.
Fix concurrency test
The default concurrency value is based on what Etc::SC_OPEN_MAX (ulimit) is set to, either divided by 7 or capped at 100. When running unit tests in an environment where this value is less than 700, it results in a number less than the expected 100. Instead, the test is now two tests where the call is stubbed and we verify both the divide by 7 and the 100 cap behavior.
Checklist
I have:
Signed-off-byannotation to each of my commits