Fix nats-servers format in docs, examples, and specs#224
Closed
Fix nats-servers format in docs, examples, and specs#224
Conversation
The Ruby MCollective server_resolver splits middleware_hosts on ':', so 'nats://broker:4222' produces three elements instead of two and breaks the NATS connection. The correct format is 'host:port' without the nats:// prefix because the NATS connector adds the scheme itself when constructing URIs. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
Member
Author
|
Actually, I'm going to rename the --nats flags to --choria-broker since that's a lot clearer and I'll incorporate this there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby MCollective server_resolver splits middleware_hosts on ':', so 'nats://broker:4222' produces three elements instead of two and breaks the NATS connection. The correct format is 'host:port' without the nats:// prefix because the NATS connector adds the scheme itself when constructing URIs.
Checklist
I have:
Signed-off-byannotation to each of my commits