Merged
Conversation
kenyon
approved these changes
Sep 16, 2025
Contributor
Author
|
I don't get why the tests fail now 🤔 |
Contributor
Author
|
let's see if the original action works when we revert the bug: #69 |
Contributor
Author
|
it passes with windows-latest and ruby 3.2 in #69 🤔 . And windows-latest is windows-2022. |
Contributor
Author
|
Now windows-latest / ruby 3.4 passed. I think the windows apply tests are just very very unreliable. |
We introduced a regression in 661c5f9 where the operating system was changed, but later on is a test for the os string. both need to match.
Contributor
Author
|
fine now \o/ |
kenyon
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced a regression in 661c5f9 where the operating system was changed, but later on is a test for the os string. both need to match.