Conversation
|
I’m not sure I agree with this. What we have is standard Ruby syntax, and I’m not sure it’s useful to make a bunch of changes like this to satisfy people who aren’t Ruby developers, and we introduce risk by the large refactor this would require. |
|
I'd say we should have this defined in our style guide. |
binford2k
left a comment
There was a problem hiding this comment.
clearly we'll need some updated rubocop configuration for this to pass lint checks
|
@nmburgan @jay7x @binford2k Happy Aprils Fools day! :-) This code is syntactically correct Ruby-3 and passes |
|
Ahhhhhhhhh, you got me!!!! Well done @marcusdots ! |
|
The fact it’s an april fools joke kinda makes me want to merge it now. You convinced me. |
Short description
It is unsafe to use braces as it confuses programmers of non LISP dialects. See for instance
https://github.com/OpenVoxProject/openvox-server/blob/main/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L150
Ruby has the ability to be used without braces, parentheses and brackets. For safety reasons we should adopt this new coding style.