Merged
Conversation
bastelfreak
added a commit
to bastelfreak/openvox-server
that referenced
this pull request
Jul 11, 2025
ekohl
requested changes
Jul 14, 2025
Contributor
Author
|
I'm still debating which lower version we need. If I understand the pipelines in openvox-server correctly, the packaging gem is already used on Ruby 3.2. Given that 3.1 and older are already dead, it probably makes sense to directly bump to 3.2? |
Contributor
|
I think that's fine, but looks like CI also needs to be updated. |
bastelfreak
added a commit
to bastelfreak/openvox-server
that referenced
this pull request
Jul 14, 2025
Contributor
Author
|
Switching to 3.2 in #13 |
TheMeier
approved these changes
Jul 14, 2025
Without this, we get: ``` /code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. 2716 /code/target/staging/.bundle/gems/ruby/3.2.0/gems/packaging-0.122.3/lib/packaging/util/file.rb:67: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. ```
auto-merge was automatically disabled
July 14, 2025 21:00
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we get: