fix(aia): add support for aia xtopei csr #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poemonsense
reviewed
Nov 21, 2024
Member
poemonsense
left a comment
poemonsense
left a comment
There was a problem hiding this comment.
Look good to me except the warning message when aia is not supported in the REF
| inline void aia_xtopei(struct AIAXtopei &xtopei) { | ||
| if (ref_aia_xtopei) { | ||
| ref_aia_xtopei(&xtopei); | ||
| } |
Member
There was a problem hiding this comment.
Should we print something here to tell the user the API has not been implemented in the REF?
poemonsense
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for NEMU to use the value of the
xtopiregister for interrupt handling, we need to update thextopiregister in NEMU. Since NEMU does not support the out-of-core part of AIA, we need to use the value ofxtopeiwhen updatingxtopi, so we passxtopeithrough the difftest framework.