Skip to content

Add formal verification for the Governor system #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 72 commits into
base: master
Choose a base branch
from
Draft

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 10, 2023

Fixes LIB-746

WIP

@Amxx Amxx added ignore-changeset formal-verification Enable FV run in a PR. labels Mar 10, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

⚠️ No Changeset found

Latest commit: aaa5a5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

⚠️ No Changeset found

Latest commit: f35c824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator Author

Amxx commented May 4, 2023

Note: I wanted to do

node certora/run.js GovernorStates --options="--rule stateTransitionWait"

But that caused issues with options including spaces. So I moved the .flatMap(opt => opt.split(' ')) to inside the runCertora function

@frangio can you see any issue with that ?

@frangio
Copy link
Contributor

frangio commented May 4, 2023

No, that makes sense. I don't think it's ideal the way we're handling options but it works.

@Amxx
Copy link
Collaborator Author

Amxx commented May 5, 2023

FYI: main (only?) remaining blocker is the stateTransitionFn function timming out.

It appears that it only reason it used to pass was because of poorly written formula and mistakes in the associativity of operators. Rewritting them cleanly (or adding parenthesis) causes it to timeout. An option could be to split that rule into multiple rules with limited logic in each one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants