Fix leading-underscore rule for constant variables

[VolodymyrBg]

Fixes #XXXX

Description

This PR implements the TODO in the solhint-custom/index.js file to expand the leading-underscore rule for constant variables. The rule now checks all constant variables regardless of their visibility, not just private ones.

Previously, the rule only checked private constant variables for leading underscores, but according to the coding standards, no constant variables should have leading underscores regardless of their visibility.

Changes

• Modified the leading-underscore rule in scripts/solhint-custom/index.js to check all constant variables for leading underscores, not just private ones
• Removed the TODO comment as the issue is now fixed

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: e3cfe22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Amxx]

Already covered by #5497