Skip to content

fix(test): remove redundant nullish coalescing in ERC721 behavior tests #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 2 commits into from
Dec 15, 2025
+2 −4
Merged

fix(test): remove redundant nullish coalescing in ERC721 behavior tests #6199

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c38bc7
fix(test): remove redundant nullish coalescing in ERC721 behavior tests
davidjsonn Dec 11, 2025
1a34dce
Update ERC721.behavior.js
Amxx Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/token/ERC721/ERC721.behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,15 +480,15 @@ function shouldBehaveLikeERC721() {

const itApproves = function () {
it('sets the approval for the target address', async function () {
expect(await this.token.getApproved(tokenId)).to.equal(this.approved ?? this.approved);
expect(await this.token.getApproved(tokenId)).to.equal(this.approved);
});
};

const itEmitsApprovalEvent = function () {
it('emits an approval event', async function () {
await expect(this.tx)
.to.emit(this.token, 'Approval')
.withArgs(this.owner, this.approved ?? this.approved, tokenId);
.withArgs(this.owner, this.approved, tokenId);
});
};

Expand Down
Loading