Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
fc2d30a
chore: fix minor typos in specs (#6204)
MoNyAvA Dec 15, 2025
bc9659f
fix(test): remove redundant nullish coalescing in ERC721 behavior tes…
davidjsonn Dec 15, 2025
b1df0c2
fix: _useNonce documentation in NoncesKeyed (#6198)
kurahin Dec 15, 2025
566c314
fix: align EnumerableMap FV comments with invariants (#6190)
SashaMalysehko Dec 15, 2025
7d2fc5f
docs(governor): correct Natspec to reference ICompoundTimelock (#6114)
phrwlk Dec 15, 2025
cbe95aa
docs: remove legacy constructor visibility from upgradeable diff exam…
Fibonacci747 Dec 15, 2025
0f25b21
Merge branch 'master' into typo-fixes
Amxx Dec 19, 2025
e0cdb24
fix(docs): correct variable names in Math library example (#6213)
PivasDesant Dec 19, 2025
220d8fd
perf: defer signer() read in SignerECDSA (#6211)
Azzurra88 Dec 19, 2025
16a82a1
docs(ERC20Burnable): Fix parameter name typo in burnFrom documentatio…
letmehateu Dec 21, 2025
d5ec62a
Merge branch 'master' into typo-fixes
Amxx Dec 22, 2025
cd69dc4
docs: fix minor typo (#6236)
andrewshab3 Dec 23, 2025
f889b7d
Fix minor typos in ShortStrings and RLP docs (#6238)
sashaodessa Dec 23, 2025
5361706
Merge branch 'master' into typo-fixes
Amxx Dec 27, 2025
775957b
fix: remove redundant Context inheritance from ERC20Burnable (#6245)
forkfury Dec 27, 2025
9e839d1
docs: add missing contract references to README files (#6201)
eeemmmmmm Dec 31, 2025
750453e
docs(governance): fix ethers.js v5 API usage in code example (#6248)
letmehateu Jan 5, 2026
dfc39ef
Merge branch 'master' into typo-fixes
Amxx Jan 5, 2026
419426a
Merge branch 'master' into typo-fixes
Amxx Jan 7, 2026
0ecef0b
docs: fix typo in ERC1155 example contract name (#6265)
andrewshab3 Jan 7, 2026
82efe00
Remove duplicate call in `VestingWalletCliff` constructor (#6278)
viktorking7 Jan 13, 2026
235359e
Merge branch 'master' into typo-fixes
arr00 Jan 13, 2026
9ba3e0c
docs:fix minor typo (#6222)
letmehateu Jan 15, 2026
f6c3421
fix: documentation typos in governance and FV guides (#6233)
maradini77 Jan 15, 2026
8998c73
docs: fix super quorum fraction NatSpec (#6205)
lisenokdonbassenok Jan 15, 2026
70d9444
Merge branch 'master' into typo-fixes
Amxx Jan 19, 2026
4ed7df7
fix: fix incorrect recipient in Address.sendValue test (#6295)
letmehateu Jan 19, 2026
19a448e
Merge branch 'master' into typo-fixes
Amxx Feb 2, 2026
ae31c1a
Fix typos in TrieProof documentation (#6318)
anim001k Feb 2, 2026
14b40f3
Remove unecessary type referencing
Amxx Feb 4, 2026
bbd483a
Merge branch 'master' into typo-fixes
Amxx Feb 26, 2026
0bc213f
fix: correct parameter reference in decodeContentsDescr comment (#6347)
MozirDmitriy Feb 26, 2026
2ce1781
docs: fix incorrect param descriptions in SafeERC20 safeApprove (#6335)
reallesee Feb 26, 2026
bbc3f83
Merge branch 'master' into typo-fixes
Amxx Mar 4, 2026
c2fecf8
docs: fix NatSpec for checkOnERC1155BatchReceived referencing wrong c…
bobtajson Mar 4, 2026
10e20dd
Fix typos and grammatical errors across codebase (#6326)
anim001k Mar 4, 2026
0c7d8be
docs: fix incorrect comments in AccessControl and AccessManager (#6336)
bobtajson Mar 4, 2026
bfbbc28
Merge branch 'master' into typo-fixes
Amxx Mar 6, 2026
3e29c91
docs: fix NatSpec wording in ERC20FlashMint (#6397)
Aboudjem Mar 6, 2026
dc918e6
Merge branch 'master' into typo-fixes
Amxx Mar 13, 2026
43daf24
docs: fix typos in BridgeMultiToken.sol (#6407)
andrewshab3 Mar 13, 2026
29313cc
docs: fix grammar (#6409)
bobtajson Mar 19, 2026
c83a6d5
Merge branch 'master' into typo-fixes
Amxx Mar 25, 2026
7ac3ce1
N-32: Fix `ERC721Consecutive` NatSpec for `_mintConsecutive` when `ba…
gonzaotc Mar 25, 2026
131d2ec
Merge branch 'master' into typo-fixes
Amxx May 14, 2026
781805e
Merge branch 'master' into typo-fixes
Amxx May 17, 2026
d16856d
fix(utils/Create3): correct verb form in _computeCreateAddress NatSpe…
0xAxiom May 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/utils/NoncesKeyed.sol
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ abstract contract NoncesKeyed is Nonces {
/**
* @dev Consumes the next unused nonce for an address and key.
*
* Returns the current value without the key prefix. Consumed nonce is increased, so calling this function twice
* Returns the current value with the key prefix (i.e. the packed keyNonce). Consumed nonce is increased, so calling this function twice
* with the same arguments will return different (sequential) results.
*/
function _useNonce(address owner, uint192 key) internal virtual returns (uint256) {
Expand Down
2 changes: 1 addition & 1 deletion fv/specs/AccessControlDefaultAdminRules.spec
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ invariant defaultAdminRoleAdminConsistency()
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
*/
// Writing this as an invariant would be flagged by Certora as trivial. Writing it as a rule is just as valid: we
// verify the is true for any state of the storage
// verify this is true for any state of the storage
rule ownerConsistency() {
assert defaultAdmin() == owner();
}
Expand Down
2 changes: 1 addition & 1 deletion fv/specs/ERC20Wrapper.spec
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ invariant totalSupplyIsSmallerThanUnderlyingBalance()
require sumOfUnderlyingBalancesLowerThanUnderlyingSupply(from, to);
}
preserved ERC20PermitHarness.burn(address from, uint256 amount) with (env e) {
// If someone can burn from the wrapper, than the invariant obviously doesn't hold.
// If someone can burn from the wrapper, then the invariant obviously doesn't hold.
require from != currentContract;
require sumOfUnderlyingBalancesLowerThanUnderlyingSupply(from, currentContract);
}
Expand Down
6 changes: 2 additions & 4 deletions test/token/ERC721/ERC721.behavior.js
Original file line number Diff line number Diff line change
Expand Up @@ -480,15 +480,13 @@ function shouldBehaveLikeERC721() {

const itApproves = function () {
it('sets the approval for the target address', async function () {
expect(await this.token.getApproved(tokenId)).to.equal(this.approved ?? this.approved);
expect(await this.token.getApproved(tokenId)).to.equal(this.approved);
});
};

const itEmitsApprovalEvent = function () {
it('emits an approval event', async function () {
await expect(this.tx)
.to.emit(this.token, 'Approval')
.withArgs(this.owner, this.approved ?? this.approved, tokenId);
await expect(this.tx).to.emit(this.token, 'Approval').withArgs(this.owner, this.approved, tokenId);
});
};

Expand Down
Loading