Consolidate the github setup action

[Amxx]

Refactor setup action to include java, python and solc as optional setup steps to clean up places where these are used.

Move all the versions of the different tools used to a single file, without env var, so that it can be more easily maintained (by AI?)

[changeset-bot]

⚠️ No Changeset found

Latest commit: abbc7d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes consolidate tool setup across GitHub Actions workflows by introducing configurable inputs (withNpm, withFoundry, withJava, withPython, withSolc) to the setup action. The setup action now conditionally installs each tool based on input flags. Corresponding workflow files have been updated to remove standalone installation steps for Python, Java, Solidity, and npm dependencies, instead passing the appropriate flags to the consolidated setup action. Environment variable declarations for these tools have been moved or removed from workflow top-level environments.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description accurately captures the main objectives: refactoring to make Java, Python, and solc optional setup steps, and centralizing tool version declarations into a single file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately summarizes the main change: consolidating the GitHub setup action to make optional tooling configurable. It clearly reflects the primary objective of refactoring the setup workflow.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch CI/update-setup-action

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 308c491 and 207b7cc.

📒 Files selected for processing (2)

• .github/actions/setup/action.yml
• .github/workflows/formal-verification.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Redirect rules - solidity-contracts
• GitHub Check: Header rules - solidity-contracts
• GitHub Check: Pages changed - solidity-contracts
• GitHub Check: slither
• GitHub Check: tests
• GitHub Check: coverage
• GitHub Check: tests-upgradeable
• GitHub Check: halmos

🔇 Additional comments (8)

.github/workflows/formal-verification.yml (3)

24-24: LGTM! Label-based gating looks correct.

The conditional logic properly checks for both the formal-verification and formal-verification-force-all labels to control when the verify job runs.

---

29-32: LGTM! Consolidated setup configuration.

The setup action is correctly invoked with the required tool flags for formal verification (Java, Python, and Solc).

---

57-57: LGTM! Minimal tooling for Halmos.

Correctly requests only Python setup, which is appropriate for the Halmos verification task.

.github/actions/setup/action.yml (5)

3-23: LGTM! Well-structured input declarations.

The input declarations are clear with appropriate defaults:

• npm and Foundry enabled by default (common requirements)
• Java, Python, and Solc disabled by default (specialized tools)

---

28-44: LGTM! Proper conditional npm setup.

The Node.js and npm setup logic correctly:

• Guards all npm-related steps with the withNpm flag
• Leverages caching to avoid redundant installations
• Only runs npm ci when cache misses

---

45-50: LGTM! Conditional Foundry installation.

The Foundry setup is correctly guarded and uses the stable version from the official toolchain action.

---

51-57: Java 21 setup is compatible with Certora.

The Java 21 configuration using the Temurin distribution aligns with Certora's documented requirements, which support Java 21 or newer.

---

58-69: Python 3.13 is compatible with both formal verification dependencies.

Both certora-cli==8.3.1 (requires Python >=3.8) and halmos==0.3.3 (requires Python >=3.11) have confirmed Python 3.13 support with available wheels. No compatibility issues exist.