test: add missing test cases for AccessManaged

[PivasDesant]

Adds three missing test cases to improve coverage:

• Test that setAuthority reverts when address(0) is provided
• Test that restricted modifier reverts when operation expires
• Test that multiple authority changes work correctly and restricted modifier functions after each change

These tests cover edge cases that were previously untested but are important for contract security.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1d8e24e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request adds new test cases to the AccessManaged test suite. These tests cover expiration handling by scheduling operations and advancing time past the expiration point to verify revert behavior. Tests validate that setting authority to address(0) raises appropriate errors. Additional tests exercise authority transitions, changing from an original authority to an alternative one, configuring roles under the new authority, verifying function access restrictions, and then reverting back to the original authority to reconfirm access controls. Tests utilize EXPIRATION constants imported from test helpers and validate correct operation identifiers in error conditions.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding missing test cases for the AccessManaged contract.
Description check	✅ Passed	The description is directly related to the changeset, providing clear details about the three new test cases being added for AccessManaged.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 001169b and 1d8e24e.

📒 Files selected for processing (1)

• test/access/manager/AccessManaged.test.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: Redirect rules - solidity-contracts
• GitHub Check: Header rules - solidity-contracts
• GitHub Check: Pages changed - solidity-contracts
• GitHub Check: halmos
• GitHub Check: slither
• GitHub Check: tests-upgradeable
• GitHub Check: coverage
• GitHub Check: tests
• GitHub Check: tests-foundry

🔇 Additional comments (3)

test/access/manager/AccessManaged.test.js (3)

7-7: LGTM! Import is necessary for the expiration test.

The EXPIRATION constant is appropriately imported and used in the new test case to verify expiration behavior.

---

139-143: LGTM! Edge case properly covered.

This test correctly validates that setting the authority to the zero address reverts with the appropriate error, covering an important security edge case.

---

153-183: LGTM! Comprehensive test for authority transitions.

This test thoroughly validates multiple authority changes and confirms the restricted modifier functions correctly after each transition. The test properly:

• Impersonates each authority to authorize changes
• Configures roles under both authorities
• Verifies function access after each change
• Tests reverting to the original authority

The test provides excellent coverage for authority change edge cases.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}