Skip to content

Conversation

@Azzurra88
Copy link

Removes unused IERC165 imports from AccessControlEnumerable and AccessControlDefaultAdminRules, updates comments to reference AccessControl instead.

@Azzurra88 Azzurra88 requested a review from a team as a code owner January 3, 2026 12:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2026

⚠️ No Changeset found

Latest commit: eb4dae5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 3, 2026

Walkthrough

This PR removes unused IERC165 imports from two AccessControl extension contracts: AccessControlDefaultAdminRules and AccessControlEnumerable. The NatSpec documentation for the supportsInterface method in both files is updated to reference AccessControl instead of IERC165 as the documentation inheritance source. No runtime behavior or function signatures are affected by these changes.

Possibly related PRs

  • Remove unused imports #6227: Removes unused IERC165 imports from the base AccessControl contract, providing consistent cleanup across the access control module.

Suggested labels

ignore-changeset

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused IERC165 imports from AccessControl extension contracts.
Description check ✅ Passed The description is directly related to the changeset, explaining both the import removals and comment updates made in the two affected files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a83d9aa and eb4dae5.

📒 Files selected for processing (2)
  • contracts/access/extensions/AccessControlDefaultAdminRules.sol
  • contracts/access/extensions/AccessControlEnumerable.sol
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: slither
  • GitHub Check: tests-upgradeable
  • GitHub Check: coverage
  • GitHub Check: tests-foundry
  • GitHub Check: tests
  • GitHub Check: halmos
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
🔇 Additional comments (2)
contracts/access/extensions/AccessControlDefaultAdminRules.sol (1)

63-66: LGTM! Documentation update is consistent and accurate.

The change from @inheritdoc IERC165 to @inheritdoc AccessControl correctly reflects that this contract overrides supportsInterface from its immediate parent AccessControl. The removal of the unused IERC165 import maintains a cleaner dependency graph.

contracts/access/extensions/AccessControlEnumerable.sol (1)

18-21: LGTM! Documentation update accurately reflects the inheritance hierarchy.

The change from @inheritdoc IERC165 to @inheritdoc AccessControl is correct since AccessControlEnumerable overrides the supportsInterface method from AccessControl, not directly from the IERC165 interface. The removal of the unused IERC165 import is a good cleanup with no remaining references to it in the file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arr00 arr00 added documentation Inline comments, guides, and examples. ignore-changeset labels Jan 6, 2026
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Docs render accurately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Inline comments, guides, and examples. ignore-changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants