-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Remove unused IERC165 imports from AccessControl extensions #6256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove unused IERC165 imports from AccessControl extensions #6256
Conversation
|
WalkthroughThis PR removes unused IERC165 imports from two AccessControl extension contracts: AccessControlDefaultAdminRules and AccessControlEnumerable. The NatSpec documentation for the supportsInterface method in both files is updated to reference AccessControl instead of IERC165 as the documentation inheritance source. No runtime behavior or function signatures are affected by these changes. Possibly related PRs
Suggested labels
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
arr00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Docs render accurately.
Removes unused IERC165 imports from AccessControlEnumerable and AccessControlDefaultAdminRules, updates comments to reference AccessControl instead.