Skip to content

Conversation

@andrewshab3
Copy link

Fixes #????

Rename MyERC115HolderContract to MyERC1155HolderContract to correctly reflect the ERC-1155 standard.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@andrewshab3 andrewshab3 requested a review from a team as a code owner January 6, 2026 22:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

⚠️ No Changeset found

Latest commit: 40d00d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

Walkthrough

A contract in the ERC1155 mock documentation folder is renamed from MyERC115HolderContract to MyERC1155HolderContract to correct a typo in the name. The contract declaration and the header comment are both updated to reflect the corrected name. The contract retains its inheritance from ERC1155Holder.

Suggested labels

ignore-changeset, typo

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a typo in the ERC1155 example contract name (MyERC115 → MyERC1155).
Description check ✅ Passed The description is directly related to the changeset, explaining the rename from MyERC115HolderContract to MyERC1155HolderContract to correctly reflect the ERC-1155 standard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI Agents
In @contracts/mocks/docs/token/ERC1155/MyERC115HolderContract.sol:
- Line 1: Rename the source file from MyERC115HolderContract.sol to
MyERC1155HolderContract.sol so the filename matches the corrected contract name
MyERC1155HolderContract; then update the documentation reference in
docs/modules/ROOT/pages/erc1155.adoc (around line 115) to point to the new
filename MyERC1155HolderContract.sol. Ensure any imports or test references that
referenced MyERC115HolderContract.sol are also updated to the new filename.
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 884e2f6 and 08f36d7.

📒 Files selected for processing (1)
  • contracts/mocks/docs/token/ERC1155/MyERC115HolderContract.sol
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
  • GitHub Check: coverage
  • GitHub Check: halmos
  • GitHub Check: tests-upgradeable
  • GitHub Check: tests
  • GitHub Check: slither
  • GitHub Check: tests-foundry

@Amxx Amxx changed the base branch from master to typo-fixes January 7, 2026 10:23
@Amxx Amxx merged commit 0ecef0b into OpenZeppelin:typo-fixes Jan 7, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants