test: Extending coverage for property based tests

[NicoMolinaOZ]

Summary

https://linear.app/openzeppelin-development/issue/PLAT-6046/add-pbt-for-chain-specific-logic

• Adding PBT for functions that are not being covered properly.
• Deleting unused code (after the big refactor, I found some functions not being used anymore)

Testing Process

Checklist

• Add a reference to related issues in the PR description.
• Add unit tests if applicable.
• Add integration tests if applicable.
• Add property-based tests if applicable.
• Update documentation if applicable.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.3%. Comparing base (f02a137) to head (c050330).

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #220     +/-   ##
=======================================
+ Coverage   95.8%   96.3%   +0.4%     
=======================================
  Files         73      73             
  Lines      24373   24225    -148     
=======================================
- Hits       23367   23333     -34     
+ Misses      1006     892    -114     

Flag	Coverage Δ
integration	59.1% <57.6%> (+0.3%)	⬆️
properties	33.0% <92.3%> (+6.5%)	⬆️
unittests	87.1% <97.2%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shahnami]

LGTM! Thanks for the hard work!

[shahnami]

@NicoMolinaOZ before merging, any idea why our overall test coverage actually is going down after this PR (95.9% -> 95.6%)

I ask because 2 days ago this PR was bumping it to 96.3 👀

[NicoMolinaOZ]

@NicoMolinaOZ before merging, any idea why our overall test coverage actually is going down after this PR (95.9% -> 95.6%)

I ask because 2 days ago this PR was bumping it to 96.3 👀

Good catch, I didn't realize yesterday. I am running the tests again, sometimes codecov made mistakes,

[NicoMolinaOZ]

@NicoMolinaOZ before merging, any idea why our overall test coverage actually is going down after this PR (95.9% -> 95.6%)

I ask because 2 days ago this PR was bumping it to 96.3 👀

After running the tests is showing 96.3% again 👀