Skip to content

refactor: Use solely websocket for RPC requests #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shahnami
Copy link
Member

@shahnami shahnami commented May 23, 2025

Summary

https://linear.app/openzeppelin-development/issue/PLAT-6664/replace-http-midnight-client-with-wsmidnightclient-entirely

  • Replaces HTTP Midnight client with Websocket Midnight client entirely
  • Makes ws_rpc mandatory for Midnight
  • Fixes and add relevant tests
  • Updates documentation

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.
  • Add integration tests if applicable.
  • Add property-based tests if applicable.
  • Update documentation if applicable.

Sorry, something went wrong.

@shahnami shahnami marked this pull request as ready for review May 27, 2025 08:39
Copy link
Contributor

@NicoMolinaOZ NicoMolinaOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahnami shahnami merged commit 7f3faf0 into plat-6659-refactor-rpc-calls-to-use-substrate-client-with-websocket Jun 2, 2025
7 checks passed
@shahnami shahnami deleted the plat-6664-replace-http-midnight-client-with-wsmidnightclient-entirely branch June 2, 2025 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants