-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Introduce TransportError
#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nTransport` trait and `EndpointManager`, update mocks and tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
- Coverage 96.0% 96.0% -0.1%
=======================================
Files 66 67 +1
Lines 20002 20206 +204
=======================================
+ Hits 19213 19404 +191
- Misses 789 802 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the improvement.
Could you just tackle a few of the missing coverage lines in endpoint_manager
?
They seem like an easy-win for our overall coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @isSerge!
@shahnami I have added additional test for |
Summary
This PR introduces
TransportError
and replacesanyhow
errors insend_raw_request
methods.This is a necessary step to improve error parsing, briefly discussed in #242
Testing Process
Checklist