Skip to content

refactor(app): prettify the historical run log offsets accordion #52912

refactor(app): prettify the historical run log offsets accordion

refactor(app): prettify the historical run log offsets accordion #52912

Triggered via push March 21, 2025 00:06
Status Failure
Total duration 9m 35s
Artifacts

js-check.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 10 warnings
js checks: app/src/organisms/Desktop/Devices/ProtocolRun/__tests__/ProtocolRunSetup.test.tsx#L198
Argument of type '{ launchLPC: Mock<Procedure>; lpcProps: null; showLPC: false; isLaunchingLPC: false; }' is not assignable to parameter of type 'UseLPCFlowsResult'.
js checks
Process completed with exit code 2.
js checks: app/src/redux/protocol-runs/types/lpc/labware.ts#L7
All imports in the declaration are only used as types. Use `import type`
js checks
Process completed with exit code 2.
js checks: app-shell-odd/src/actions.ts#L360
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L368
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L376
Expected property shorthand
js checks: app-shell-odd/src/actions.ts#L384
Expected property shorthand
js checks: app-shell-odd/src/dialogs/index.ts#L27
Don't use `String` as a type. Use string instead
js checks: app-shell-odd/src/dialogs/index.ts#L38
This assertion is unnecessary since it does not change the type of the expression
js checks: app-shell-odd/src/dialogs/index.ts#L61
This assertion is unnecessary since it does not change the type of the expression
js checks: app-shell-odd/src/http.ts#L75
Unexpected number value in conditional. An explicit zero/NaN check is required
js checks: app-shell-odd/src/http.ts#L102
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
js checks: app-shell-odd/src/http.ts#L131
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator