Skip to content

Commit

Permalink
fix(protocol-designer): fix copy & link for custom labware (#4232)
Browse files Browse the repository at this point in the history
  • Loading branch information
IanLondon authored Oct 15, 2019
1 parent 1d1d1da commit 1490f65
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import startCase from 'lodash/startCase'
import reduce from 'lodash/reduce'
import i18n from '../../localization'
import { getOnlyLatestDefs } from '../../labware-defs/utils'
import KnowledgeBaseLink from '../KnowledgeBaseLink'
import { Portal } from '../portals/TopPortal'
import { PDTitledList } from '../lists'
import LabwareItem from './LabwareItem'
Expand All @@ -27,6 +26,7 @@ type Props = {
permittedTipracks: Array<string>,
}

const LABWARE_CREATOR_URL = 'https://labware.opentrons.com/create'
const CUSTOM_CATEGORY = 'custom'

const orderedCategories: Array<string> = [
Expand Down Expand Up @@ -151,9 +151,15 @@ const LabwareDropdown = (props: Props) => {
</OutlineButton>
<div className={styles.upload_helper_copy}>
{i18n.t('modal.labware_selection.creating_labware_defs')}{' '}
<KnowledgeBaseLink className={styles.link} to="customLabware">
{/* TODO: Ian 2019-10-15 use LinkOut component once it's in components library, see Opentrons/opentrons#4229 */}
<a
className={styles.link}
href={LABWARE_CREATOR_URL}
target="_blank"
rel="noopener noreferrer"
>
here
</KnowledgeBaseLink>
</a>
.
</div>

Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/src/localization/en/modal.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"max_vol": "Max Volume",
"see_details": "See detail page",
"view_measurements": "view measurements",
"creating_labware_defs": "Learn more about creating custom labware definitions"
"creating_labware_defs": "Access the Labware Creator"
},
"tip_position": {
"title": "Tip Positioning",
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const PROTOCOL_DESIGNER_ENV_VAR_PREFIX = 'OT_PD_'
// Also remove all OT_PD_VERSION env vars, the version should always
// be gleaned from the package.json

const OT_PD_VERSION = '3.0.5'
const OT_PD_VERSION = '3.0.6'
const OT_PD_BUILD_DATE = new Date().toUTCString()

const JS_ENTRY = path.join(__dirname, 'src/index.js')
Expand Down

0 comments on commit 1490f65

Please sign in to comment.