Skip to content

Commit

Permalink
remove spurious TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jbleon95 committed Jul 31, 2024
1 parent 81dc5ae commit 2588ce2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ def extract_run_parameters(
protocol: PythonProtocol,
parameter_context: ParameterContext,
run_time_param_overrides: Optional[PrimitiveRunTimeParamValuesType],
# TODO maybe this one too
run_time_param_file_overrides: Optional[CSVRuntimeParamPaths],
) -> Optional[Parameters]:
"""Extract the parameters defined in the protocol, overridden with values for the run."""
Expand Down
1 change: 0 additions & 1 deletion api/src/opentrons/protocol_runner/run_orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ def get_loaded_labware_definitions(self) -> List[LabwareDefinition]:
"""Get loaded labware definitions."""
return self._protocol_engine.state_view.labware.get_loaded_labware_definitions()

# TODO make sure this returns CSV parameters here
def get_run_time_parameters(self) -> List[RunTimeParameter]:
"""Get the list of run time parameters defined in the protocol, if any.
Expand Down

0 comments on commit 2588ce2

Please sign in to comment.