fix(app): fix error recovery crashing the app

Opentrons · Jul 30, 2024 · 559dc22 · 559dc22
1 parent 51838a5
commit 559dc22
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/src/organisms/ErrorRecoveryFlows/__tests__/ErrorRecoveryFlows.test.tsx b/app/src/organisms/ErrorRecoveryFlows/__tests__/ErrorRecoveryFlows.test.tsx
@@ -218,7 +218,7 @@ describe('ErrorRecoveryFlows', () => {
 
     const newProps = {
       ...props,
-      failedCommand: { ...mockFailedCommand, id: 'NEW_ID' },
+      failedCommand: null,
     }
     rerender(<ErrorRecoveryFlows {...newProps} />)
     expect(mockReportErrorEvent).toHaveBeenCalledWith(newProps.failedCommand)

diff --git a/app/src/organisms/ErrorRecoveryFlows/index.tsx b/app/src/organisms/ErrorRecoveryFlows/index.tsx
@@ -121,7 +121,7 @@ export function ErrorRecoveryFlows(
   const analytics = useRecoveryAnalytics()
   React.useEffect(() => {
     analytics.reportErrorEvent(failedCommand)
-  }, [failedCommand])
+  }, [failedCommand?.key])
 
   const { hasLaunchedRecovery, toggleERWizard, showERWizard } = useERWizard()
   const isOnDevice = useSelector(getIsOnDevice)