Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(api): show air gap volume in simulate log (#17569)
# Overview When `simulate`-ing a protocol, the logs just show this for an `AIR_GAP` command: ``` Air gap Logs from this command: INFO (publisher): command.AIR_GAP: ``` whereas the other commands have useful info. I want to see how much air we're aspirating for the air gap. After this change, the logs will look like this: ``` Air gap of 11.5 uL Logs from this command: INFO (publisher): command.AIR_GAP: instrument: Flex 1-Channel 50 µL on right mount, volume: 11.5, height: None ``` ## Test Plan and Hands on Testing I'm mainly relying on the CI tests. I did run `simulate` with this change and checked the output manually. ## Review requests I am not too familiar with this part of the code. - Why is the implementation of the simulate logger in `legacy_commands`? What does "legacy" refer to? - I don't quite understand how arguments are passed to the functions in `legacy_commands/commands.py`. How was the code able to work when the function was declared as `def air_gap()` with no arguments before this change ## Risk assessment Medium? I don't know if there are consumers of the simulate log who expect the payload never to change.
- Loading branch information