Skip to content

Commit

Permalink
fix(shared-data): Restore "lid" display category missing from labware…
Browse files Browse the repository at this point in the history
… schema 3 (#17480)
  • Loading branch information
SyntaxColoring authored Feb 10, 2025
1 parent 5da85c3 commit a8c1f16
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
8 changes: 3 additions & 5 deletions shared-data/js/__tests__/labwareDefSchemaV3.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,9 @@ describe(`test labware definitions with schema v3`, () => {

// FIXME(mm, 2025-02-04): These new definitions have a displayCategory that
// the schema does not recognize. Either they need to change or the schema does.
const expectFailure = [
'opentrons_flex_tiprack_lid',
'opentrons_tough_pcr_auto_sealing_lid',
'protocol_engine_lid_stack_object',
].includes(labwareDef.parameters.loadName)
const expectFailure = ['protocol_engine_lid_stack_object'].includes(
labwareDef.parameters.loadName
)

if (expectFailure) expect(validationErrors).not.toBe(null)
else expect(validationErrors).toBe(null)
Expand Down
3 changes: 2 additions & 1 deletion shared-data/labware/schemas/3.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
"wellPlate",
"aluminumBlock",
"adapter",
"other"
"other",
"lid"
]
},
"safeString": {
Expand Down

0 comments on commit a8c1f16

Please sign in to comment.