update test

Opentrons · Feb 6, 2025 · c6cca8a · c6cca8a
1 parent 8c2e416
commit c6cca8a
Show file tree

Hide file tree

Showing 5 changed files with 64 additions and 1 deletion.
diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
@@ -39,6 +39,7 @@ interface PositionFieldProps {
   yField?: TipYOffsetFields
   labwareId?: string | null
   padding?: string
+  isWhiteButton?: boolean | null
 }
 
 export function PositionField(props: PositionFieldProps): JSX.Element {
@@ -50,6 +51,7 @@ export function PositionField(props: PositionFieldProps): JSX.Element {
     yField,
     prefix,
     padding = `0 ${SPACING.spacing16}`,
+    isWhiteButton,
   } = props
   console.log(propsForFields)
   const {
@@ -186,7 +188,7 @@ export function PositionField(props: PositionFieldProps): JSX.Element {
           </StyledText>
           <ListButton
             padding={SPACING.spacing12}
-            type="noActive"
+            type={isWhiteButton ?? false ? 'onColor' : 'noActive'}
             onClick={() => {
               handleOpen(true)
             }}

diff --git a/...r/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/MultiInputField.tsx b/...r/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/MultiInputField.tsx
@@ -91,6 +91,7 @@ export function MultiInputField(props: MultiInputFieldProps): JSX.Element {
               xField={`${prefix}_x_position`}
               yField={`${prefix}_y_position`}
               labwareId={labwareId}
+              isWhiteButton={true}
             />
           )}
         </Flex>

diff --git a/protocol-designer/src/step-forms/test/createPresavedStepForm.test.ts b/protocol-designer/src/step-forms/test/createPresavedStepForm.test.ts
@@ -161,7 +161,10 @@ describe('createPresavedStepForm', () => {
       aspirate_mix_volume: null,
       aspirate_mmFromBottom: null,
       aspirate_retract_delay_seconds: null,
+      aspirate_retract_mmFromBottom: null,
       aspirate_retract_speed: null,
+      aspirate_retract_x_position: 0,
+      aspirate_retract_y_position: 0,
       aspirate_submerge_delay_seconds: null,
       aspirate_submerge_speed: null,
       aspirate_touchTip_checkbox: false,
@@ -182,7 +185,10 @@ describe('createPresavedStepForm', () => {
       dispense_mix_volume: null,
       dispense_mmFromBottom: null,
       dispense_retract_delay_seconds: null,
+      dispense_retract_mmFromBottom: null,
       dispense_retract_speed: null,
+      dispense_retract_x_position: 0,
+      dispense_retract_y_position: 0,
       dispense_submerge_delay_seconds: null,
       dispense_submerge_speed: null,
       dispense_touchTip_checkbox: false,

diff --git a/protocol-designer/src/steplist/formLevel/test/getDefaultsForStepType.test.ts b/protocol-designer/src/steplist/formLevel/test/getDefaultsForStepType.test.ts
@@ -35,7 +35,10 @@ describe('getDefaultsForStepType', () => {
         aspirate_mix_volume: null,
         aspirate_mmFromBottom: null,
         aspirate_retract_delay_seconds: null,
+        aspirate_retract_mmFromBottom: null,
         aspirate_retract_speed: null,
+        aspirate_retract_x_position: 0,
+        aspirate_retract_y_position: 0,
         aspirate_submerge_delay_seconds: null,
         aspirate_submerge_speed: null,
         aspirate_touchTip_checkbox: false,
@@ -51,7 +54,10 @@ describe('getDefaultsForStepType', () => {
         dispense_mix_volume: null,
         dispense_mmFromBottom: null,
         dispense_retract_delay_seconds: null,
+        dispense_retract_mmFromBottom: null,
         dispense_retract_speed: null,
+        dispense_retract_x_position: 0,
+        dispense_retract_y_position: 0,
         dispense_submerge_delay_seconds: null,
         dispense_submerge_speed: null,
         dispense_touchTip_checkbox: false,

diff --git a/protocol-designer/src/ui/steps/test/selectors.test.ts b/protocol-designer/src/ui/steps/test/selectors.test.ts
@@ -521,10 +521,22 @@ describe('_getSavedMultiSelectFieldValues', () => {
           isIndeterminate: false,
           value: undefined,
         },
+        aspirate_retract_mmFromBottom: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         aspirate_retract_speed: {
           isIndeterminate: false,
           value: undefined,
         },
+        aspirate_retract_x_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
+        aspirate_retract_y_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         aspirate_submerge_delay_seconds: {
           isIndeterminate: false,
           value: undefined,
@@ -598,10 +610,22 @@ describe('_getSavedMultiSelectFieldValues', () => {
           isIndeterminate: false,
           value: undefined,
         },
+        dispense_retract_mmFromBottom: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         dispense_retract_speed: {
           isIndeterminate: false,
           value: undefined,
         },
+        dispense_retract_x_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
+        dispense_retract_y_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         dispense_submerge_delay_seconds: {
           isIndeterminate: false,
           value: undefined,
@@ -817,10 +841,22 @@ describe('_getSavedMultiSelectFieldValues', () => {
           isIndeterminate: false,
           value: undefined,
         },
+        aspirate_retract_mmFromBottom: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         aspirate_retract_speed: {
           isIndeterminate: false,
           value: undefined,
         },
+        aspirate_retract_x_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
+        aspirate_retract_y_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         // dispense settings
         dispense_labware: {
           isIndeterminate: true,
@@ -877,10 +913,22 @@ describe('_getSavedMultiSelectFieldValues', () => {
           isIndeterminate: false,
           value: undefined,
         },
+        dispense_retract_mmFromBottom: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         dispense_retract_speed: {
           isIndeterminate: false,
           value: undefined,
         },
+        dispense_retract_x_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
+        dispense_retract_y_position: {
+          isIndeterminate: false,
+          value: undefined,
+        },
         dispense_submerge_delay_seconds: {
           isIndeterminate: false,
           value: undefined,