-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(api): restore empty error blocks on cancelled runs (#15215)
I think this would be a subtle side effect of a previous pr trying to improve PE end behavior. The reason this fix is required is that when a client cancels a protocol by stopping the engine, the `StopAction` sets the run result (good) and doesn't set a run error (good, correct, there wasn't one, this is a cancel). In 7.2, with the behavior this PR now restores, a `FinishAction` that might contain an error wouldn't set that error in the run if it already had a _result_, whether or not it had an _error_. In 7.3, it would set the error if the engine had no error, which it wouldn't, because there is no error when you stop. ## Testing - [x] With this PR, cancelling a run on a real robot causes the ODD to show an inactive error details button - [x] With this PR, stopping a run by hitting an estop still causes the ODD and desktop to display that an estop error cancelled the run Closes RQA-2737 --------- Co-authored-by: Max Marrone <max@opentrons.com>
- v8.3.0
- v8.3.0-alpha.9
- v8.3.0-alpha.8
- v8.3.0-alpha.7
- v8.3.0-alpha.6
- v8.3.0-alpha.5
- v8.3.0-alpha.4
- v8.3.0-alpha.3
- v8.3.0-alpha.2
- v8.3.0-alpha.1
- v8.3.0-alpha.0
- v8.3.0-a.4-with-droptip-height-fix
- v8.2.0
- v8.2.0-alpha.4
- v8.2.0-alpha.3
- v8.2.0-alpha.2
- v8.2.0-alpha.1
- v8.2.0-alpha.0
- v8.1.0
- v8.1.0-alpha.0
- v8.0.0
- v8.0.0-alpha.9
- v8.0.0-alpha.8
- v8.0.0-alpha.7
- v8.0.0-alpha.6
- v8.0.0-alpha.5
- v8.0.0-alpha.4
- v8.0.0-alpha.3
- v8.0.0-alpha.2
- v8.0.0-alpha.1
- v8.0.0-alpha.0
- v7.5.0
- v7.5.0-alpha.3
- v7.5.0-alpha.2
- v7.5.0-alpha.1
- v7.5.0-alpha.0
- v7.4.0
- v7.4.0-alpha.4
- v7.4.0-alpha.3
- v7.4.0-alpha.2
- v7.4.0-alpha.1
- v7.4.0-alpha.0
- v7.3.1
- v7.3.1-alpha.1
- v7.3.1-alpha.0
- v7.3.0
- v7.3.0-beta.0
- v7.3.0-alpha.7
- v7.3.0-alpha.6
- v7.3.0-alpha.5
- robot.diagnostics-24.07.03
- protocol-designer@8.4.2
- protocol-designer@8.4.2-alpha.0
- protocol-designer@8.4.0
- protocol-designer@8.4.0-alpha.5
- protocol-designer@8.4.0-alpha.4
- protocol-designer@8.4.0-alpha.3
- protocol-designer@8.4.0-alpha.2
- protocol-designer@8.4.0-alpha.1
- protocol-designer@8.4.0-alpha.0
- protocol-designer@8.3.0
- protocol-designer@8.3.0-candidate-f
- protocol-designer@8.3.0-candidate-e
- protocol-designer@8.3.0-candidate-d
- protocol-designer@8.3.0-candidate-c
- protocol-designer@8.3.0-candidate-b
- protocol-designer@8.3.0-candidate-a
- protocol-designer@8.2.3
- protocol-designer@8.2.3-candidate-c
- protocol-designer@8.2.3-candidate-b
- protocol-designer@8.2.3-candidate-a
- protocol-designer@8.2.2
- protocol-designer@8.2.2-candidate-c
- protocol-designer@8.2.2-candidate-b
- protocol-designer@8.2.2-candidate-a
- protocol-designer@8.2.1
- protocol-designer@8.2.1-candidate-a
- protocol-designer@8.2.0
- protocol-designer@8.2.0-candidate-j
- protocol-designer@8.2.0-candidate-i
- protocol-designer@8.2.0-candidate-h
- protocol-designer@8.2.0-candidate-g
- protocol-designer@8.2.0-candidate-f
- protocol-designer@8.2.0-candidate-e
- protocol-designer@8.2.0-candidate-d
- protocol-designer@8.2.0-candidate-c
- protocol-designer@8.2.0-candidate-b
- protocol-designer@8.2.0-candidate-a
- protocol-designer@8.1.3
- protocol-designer@8.1.3-candidate-a
- protocol-designer@8.1.2
- protocol-designer@8.1.2-candidate-b
- protocol-designer@8.1.2-candidate-a
- protocol-designer@8.1.1
- protocol-designer@8.1.1-candidate-a
- protocol-designer@8.1.0
- protocol-designer@8.1.0-candidate-g
- protocol-designer@8.1.0-candidate-f
- ot3@2.4.0-alpha.2
- ot3@2.4.0-alpha.1
- ot3@2.4.0-alpha.0
- ot3@2.3.0-alpha.3
- ot3@2.3.0-alpha.2
- ot3@2.3.0-alpha.1
- ot3@2.3.0-alpha.0
- ot3@2.2.0-alpha.1
- ot3@2.2.0-alpha.0
- ot3@2.1.0-alpha.1
- ot3@2.1.0-alpha.0
- ot3@2.0.0-alpha.4
- ot3@2.0.0-alpha.3
- ot3@2.0.0-alpha.2
- ot3@2.0.0-alpha.1
- ot3@2.0.0-alpha.0
- list
- labware-library@3.2.0
- labware-library@3.2.0-alpha.0
- labware-library@3.1.0
- labware-library@3.1.0-candidate-b
- labware-library@3.1.0-candidate-a
- labware-library@3.0.2-candidate-a
- labware-library@3.0.1
- labware-library@3.0.1-candidate-e
- labware-library@3.0.1-candidate-d
- labware-library@3.0.1-candidate-c
- labware-library@3.0.1-candidate-b
- labware-library@3.0.1-candidate-a
- labware-library@3.0.0
- labware-library@3.0.0-candidate-b
- labware-library@3.0.0-candidate-a
- flex-stacker-qc-24.11.27
- flex-stacker-2025.2.14-build
- docs@2.22
- docs@2.21_1
- docs@2.21
- docs@2.20
- docs@2.19_2
- docs@2.19_1
- docs@2.19
- components@0.1.6-alpha.21
- components@0.1.6-alpha.20
- components@0.1.6-alpha.19
- components@0.1.6-alpha.18
- components@0.1.6-alpha.17
- components@0.1.6-alpha.16
- components@0.1.6-alpha.15
- components@0.1.6-alpha.14
- components@0.1.6-alpha.13
- components@0.1.6-alpha.12
- components@0.1.6-alpha.11
- components@0.1.6-alpha.10
- components@0.1.6-alpha.9
- components@0.1.6-alpha.8
- app_shell-add-license-confirmation_3_app-build
- app_shell-add-license-confirmation_2_app-build
- app_shell-add-license-confirmation_app-build-2
- app_shell-add-license-confirmation_app-build
- ai-server@0.0.10
- ai-server@0.0.9
- ai-server@0.0.7
- ai-server@0.0.6
- ai-server@0.0.5
- ai-server@0.0.4
- ai-server@0.0.3
- ai-server@0.0.2
- ai-server@0.0.1
- ai-client@0.0.9
- ai-client@0.0.8
- ai-client@0.0.7
- ai-client@0.0.6
- ai-client@0.0.5
- ai-client@0.0.4
- ai-client@0.0.3
- ai-client@0.0.2
- ai-client@0.0.1
- 96ch_200_gravimetric_24.11.22
- 96ch_200_gravimetric_24.11.21
1 parent
bb1f1ce
commit d83c4e6
Showing
2 changed files
with
45 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters