Skip to content

Commit

Permalink
remove some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
jbleon95 committed Feb 6, 2025
1 parent 38f8f20 commit d97ebae
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions api/src/opentrons/protocol_api/core/engine/instrument.py
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,6 @@ def consolidate_liquid( # noqa: C901
tip_racks: List[Tuple[Location, LabwareCore]],
trash_location: Union[Location, TrashBin, WasteChute],
) -> None:
# TODO BOILERPLATE BELOW
if not tip_racks:
raise RuntimeError(
"No tipracks found for pipette in order to perform transfer"
Expand All @@ -1263,7 +1262,6 @@ def consolidate_liquid( # noqa: C901
transfer_properties=transfer_props,
tiprack_uri=tiprack_uri_for_transfer_props,
)
# TODO BOILER PLATE ABOVE

max_volume = min(
self.get_max_volume(),
Expand All @@ -1281,7 +1279,6 @@ def consolidate_liquid( # noqa: C901
max_volume=max_volume,
)

# TODO BOILERPLATE BELOW
def _drop_tip() -> None:
if isinstance(trash_location, (TrashBin, WasteChute)):
self.drop_tip_in_disposal_location(
Expand Down Expand Up @@ -1323,8 +1320,6 @@ def _pick_up_tip() -> None:
increment=None,
)

# TODO BOILER PLATE ABOVE

if new_tip == TransferTipPolicyV2.ONCE:
_pick_up_tip()

Expand Down Expand Up @@ -1383,7 +1378,7 @@ def _pick_up_tip() -> None:
tip_contents = self.dispense_liquid_class(
volume=total_dispense_volume,
dest=dest,
source=None, # TODO Should we have a source for this? Should it be an error if blowout is source?
source=None, # Cannot have source as location for blowout so hardcoded to None
transfer_properties=transfer_props,
transfer_type=tx_comps_executor.TransferType.MANY_TO_ONE,
tip_contents=tip_contents,
Expand Down

0 comments on commit d97ebae

Please sign in to comment.