Skip to content

Commit

Permalink
Merge branch 'edge' into pd-switch-pipette
Browse files Browse the repository at this point in the history
  • Loading branch information
shiyaochen authored and shiyaochen committed Nov 20, 2024
2 parents bae1d02 + 5ed800e commit da61c78
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ interface PDListItemCustomizeProps {
label?: string
dropdown?: DropdownMenuProps
tag?: TagProps
forceDirection?: boolean
}

export function PDListItemCustomize({
Expand All @@ -38,7 +37,6 @@ export function PDListItemCustomize({
label,
dropdown,
tag,
forceDirection = false,
}: PDListItemCustomizeProps): JSX.Element {
const responsiveType = useResponsiveBreakpoints()
const isLargeScreen = responsiveType === 'xl' || responsiveType === 'lg'
Expand All @@ -53,7 +51,7 @@ export function PDListItemCustomize({
)}
{dropdown != null && (
<Flex paddingBottom={SPACING.spacing8}>
<DropdownMenu {...dropdown} forceDirection={forceDirection} />
<DropdownMenu {...dropdown} menuPlacement="bottom" />
</Flex>
)}
{tag != null && <Tag {...tag} />}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ export function SelectFixtures(props: WizardTileProps): JSX.Element | null {
return (
<ListItem type="noActive" key={ae}>
<ListItemCustomize
menuPlacement="bottom"
linkText={t('remove')}
onClick={() => {
setValue(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ export function SelectModules(props: WizardTileProps): JSX.Element | null {
return (
<ListItem type="noActive" key={`${module.model}`}>
<ListItemCustomize
menuPlacement="bottom"
dropdown={
MOAM_MODULE_TYPES.includes(module.type) &&
robotType === FLEX_ROBOT_TYPE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ export function DeckSetupDetails(props: DeckSetupDetailsProps): JSX.Element {
}
const isLabwareOccludedByThermocyclerLid =
moduleOnDeck.type === THERMOCYCLER_MODULE_TYPE &&
(moduleOnDeck.moduleState as ThermocyclerModuleState).lidOpen !== true
(moduleOnDeck.moduleState as ThermocyclerModuleState).lidOpen !==
true &&
tab === 'protocolSteps'

const tempInnerProps = getModuleInnerProps(moduleOnDeck.moduleState)
const innerProps =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@
"y": 0,
"z": 8.193
},
"biorad_96_wellplate_200ul_pcr": {
"x": 0,
"y": 0,
"z": 8.08
},
"opentrons_flex_deck_riser": {
"x": 0,
"y": 0,
Expand Down

0 comments on commit da61c78

Please sign in to comment.