Skip to content

Commit

Permalink
refactor(api): Delete obsolete todo comments (#17554)
Browse files Browse the repository at this point in the history
  • Loading branch information
SyntaxColoring authored Feb 19, 2025
1 parent 6233f7f commit f34756f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions api/src/opentrons/protocol_engine/commands/load_labware.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ async def execute( # noqa: C901
display_name=params.displayName,
)

# TODO(jbl 2023-06-23) these validation checks happen after the labware is loaded, because they rely on
# on the definition. In practice this will not cause any issues since they will raise protocol ending
# exception, but for correctness should be refactored to do this check beforehand.
if isinstance(verified_location, OnLabwareLocation):
self._state_view.labware.raise_if_labware_cannot_be_stacked(
top_labware_definition=loaded_labware.definition,
Expand Down
3 changes: 0 additions & 3 deletions api/src/opentrons/protocol_engine/commands/load_lid.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ async def execute(self, params: LoadLidParams) -> SuccessData[LoadLidResult]:
labware_id=None,
)

# TODO(chb 2024-12-12) these validation checks happen after the labware is loaded, because they rely on
# on the definition. In practice this will not cause any issues since they will raise protocol ending
# exception, but for correctness should be refactored to do this check beforehand.
if not labware_validation.validate_definition_is_lid(loaded_labware.definition):
raise LabwareCannotBeStackedError(
f"Labware {params.loadName} is not a Lid and cannot be loaded onto {self._state_view.labware.get_display_name(params.location.labwareId)}."
Expand Down

0 comments on commit f34756f

Please sign in to comment.